From owner-svn-ports-head@FreeBSD.ORG  Tue Mar 31 07:45:30 2015
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 6A71B8BF; Tue, 31 Mar 2015 07:45:30 +0000 (UTC)
Date: Tue, 31 Mar 2015 07:45:30 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Kurt Jaeger <pi@FreeBSD.org>
Subject: Re: svn commit: r382799 - head/mail/rainloop
Message-ID: <20150331074530.GA96248@FreeBSD.org>
References: <201503310733.t2V7XuXK025802@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201503310733.t2V7XuXK025802@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Mar 2015 07:45:30 -0000

On Tue, Mar 31, 2015 at 07:33:56AM +0000, Kurt Jaeger wrote:
> New Revision: 382799
> URL: https://svnweb.freebsd.org/changeset/ports/382799
> 
> Log:
>   mail/rainloop: Add an OPTIONS_DEFAULT

May I ask, why MYSQL was preferred over SQLITE?

> +OPTIONS_SINGLE=	DB
> +OPTIONS_SINGLE_DB=	MYSQL PGSQL SQLITE
> +OPTIONS_DEFAULT=	MYSQL

Two mistakes here: 1) wrong position of OPTIONS_* block (should be lower in
the Makefile), and 2) it duplicates existing knobs (OPTIONS_SINGLE and
OPTIONS_SINGLE_DB).

> @@ -28,7 +32,6 @@ PLIST_SUB=	VER="${RVER}" WWWOWN="${WWWOW
>  
>  OPTIONS_SINGLE=	DB
>  OPTIONS_SINGLE_DB=	MYSQL PGSQL SQLITE

./danfe