From owner-svn-src-head@FreeBSD.ORG  Thu Mar  4 17:58:51 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EEDFB1065674;
	Thu,  4 Mar 2010 17:58:51 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 9E3208FC12;
	Thu,  4 Mar 2010 17:58:51 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o24Hs54K003416;
	Thu, 4 Mar 2010 10:54:05 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Thu, 04 Mar 2010 10:54:23 -0700 (MST)
Message-Id: <20100304.105423.10150326159285427.imp@bsdimp.com>
To: sobomax@FreeBSD.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <4B8F3F4B.7020002@FreeBSD.org>
References: <201003032153.o23LrQwl076528@svn.freebsd.org>
	<4B8F3F4B.7020002@FreeBSD.org>
X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn: head/sbin/newfs
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Mar 2010 17:58:52 -0000

In message: <4B8F3F4B.7020002@FreeBSD.org>
            Maxim Sobolev <sobomax@FreeBSD.org> writes:
: Warner Losh wrote:
: > Author: imp
: > Date: Wed Mar  3 21:53:25 2010
: > New Revision: 204672
: > URL: http://svn.freebsd.org/changeset/base/204672
: > Log:
: >   Cast these to intmax_t before printing to fix build bustage.  Better
: >   solutions welcome.
: 
: Thanks for a quick fix and sorry for the breakage. IMHO you fix's
: fine, there is no real reason to use 64-bit quantity anyway, it's just
: because expand_number(3) interface is not very well designed and
: forces anyone using it stick with that data type. So downsizing from
: 64-bit to 32-bit on platforms where intmax_t is 32-bit only (if any)
: should not be an issue in real life.

Yea, but as others have pointed out, this seems to point out that
there's interface problems, and things have silently changed from
needing to be int to needing to be int64_t, which breaks on i386...

Warner