From owner-cvs-all@FreeBSD.ORG Thu Jun 29 10:52:56 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F198716A58F; Thu, 29 Jun 2006 10:52:56 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2340543DC3; Thu, 29 Jun 2006 10:52:46 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k5TAqgKE033860; Thu, 29 Jun 2006 06:52:42 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Sam Leffler Date: Tue, 27 Jun 2006 08:48:28 -0400 User-Agent: KMail/1.9.1 References: <200606261834.k5QIYkEF005337@repoman.freebsd.org> <44A0708C.4090703@errno.com> In-Reply-To: <44A0708C.4090703@errno.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200606270848.29250.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]); Thu, 29 Jun 2006 06:52:42 -0400 (EDT) X-Virus-Scanned: ClamAV 0.87.1/1575/Thu Jun 29 04:50:14 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_module.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jun 2006 10:52:57 -0000 On Monday 26 June 2006 19:41, Sam Leffler wrote: > John Baldwin wrote: > > jhb 2006-06-26 18:34:45 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_module.c > > Log: > > Address a problem I missed in removing Giant from the kernel linker. Not > > all of the module event handlers are MP safe yet, so always acquire Giant > > for now when invoking module event handlers. Eventually we can add an > > MPSAFE flag or some such and add appropriate locking to all module event > > handlers. > > I suggest we should be marking things !MPSAFE rather than MPSAFE. > > Sam I would prefer that as well but that would require an exhaustive search of all existing module event handlers to determine MPSAFE-ness up front. With the mark as MPSAFE method (such as we've used for syscalls) we can mark things MPSAFE (and/or add locking to make them MPSAFE) while doing the exhaustive search and eventually when all are MPSAFE we can remove the flag (which I'm in the process of doing now with the syscall flag) all the while having a functioning system. -- John Baldwin