From owner-svn-src-all@freebsd.org Thu Aug 11 17:53:55 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 99BE0BB5944; Thu, 11 Aug 2016 17:53:55 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from mx1.sbone.de (bird.sbone.de [46.4.1.90]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 5A7531C21; Thu, 11 Aug 2016 17:53:54 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 96B3C25D3A0E; Thu, 11 Aug 2016 17:53:45 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id DE8B1D1F83C; Thu, 11 Aug 2016 17:53:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id NsSPvcP8cgQz; Thu, 11 Aug 2016 17:53:42 +0000 (UTC) Received: from nv.sbone.de (nv.sbone.de [IPv6:fde9:577b:c1a9:31::2013:138]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 75ADAD1F814; Thu, 11 Aug 2016 17:53:42 +0000 (UTC) Date: Thu, 11 Aug 2016 17:53:41 +0000 (UTC) From: "Bjoern A. Zeeb" To: John Baldwin cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r303963 - head/sys/powerpc/include In-Reply-To: <1743387.a2iKJ8FVcJ@ralph.baldwin.cx> Message-ID: References: <201608111506.u7BF6DX4046653@repo.freebsd.org> <1743387.a2iKJ8FVcJ@ralph.baldwin.cx> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Aug 2016 17:53:55 -0000 On Thu, 11 Aug 2016, John Baldwin wrote: > On Thursday, August 11, 2016 03:06:13 PM Bjoern A. Zeeb wrote: >> Author: bz >> Date: Thu Aug 11 15:06:12 2016 >> New Revision: 303963 >> URL: https://svnweb.freebsd.org/changeset/base/303963 >> >> Log: >> Revert r303890 for now here as camdd fails to build on powerpc* >> due to device_t only being available under _KERNEL. >> >> Reported by: bde (_KERNEL in general), kib (build failure) >> MFC after: 1 day >> X-MFC with: r303890 > > I think the real issue though is exposting this function prototype to > userland (I looked at it the other day). camdd only wants bus_dma_segment_t. > It also explicitly includes which is a no-no. I think this > should be fixed to either define a suitable bus_dma_segment_t explicitly > in libcam.h or the bus_dma headers have to all be audited to add > appropriate #ifdef _KERNEL guards. Oh yes, I agree with you. Having looked at all places I just decided that my first priority was to get builds unbroken and then leave it to others doing the right thing (tm). camdd also has a couple of strange includes, duplicated includes (given things are implicatly included), yaddah. I won't be in the way of a cleanup unless the builds break again :) -- Bjoern A. Zeeb r15:7