From owner-svn-src-head@freebsd.org Mon Aug 10 16:46:56 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1E1B63A804E; Mon, 10 Aug 2020 16:46:56 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BQMLl74pRz4W7w; Mon, 10 Aug 2020 16:46:55 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id D13051567D; Mon, 10 Aug 2020 16:46:55 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f179.google.com with SMTP id k18so7232499qtm.10; Mon, 10 Aug 2020 09:46:55 -0700 (PDT) X-Gm-Message-State: AOAM532ZWkmkEiDk4SkDZoAMDRxQpYHIeawhZq89xZquzbt6yyJ0ypJv R5Xk3k2CCp5v0RPaS2D+E5RRGt+SZpTbTwqaLig= X-Google-Smtp-Source: ABdhPJy1Z2KfoAP6YJwXPPcmFoBUssIFT9OOwrMTG4MoNg+MB/egl5YjVm6aKuTvftw9UjmvtHD6XZHuZciAmaGJo9k= X-Received: by 2002:ac8:5546:: with SMTP id o6mr26969483qtr.211.1597078015209; Mon, 10 Aug 2020 09:46:55 -0700 (PDT) MIME-Version: 1.0 References: <202008071626.077GQvd8038727@repo.freebsd.org> In-Reply-To: <202008071626.077GQvd8038727@repo.freebsd.org> From: Kyle Evans Date: Mon, 10 Aug 2020 11:46:44 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r364030 - in head: . tools/build To: Warner Losh Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2020 16:46:56 -0000 On Fri, Aug 7, 2020 at 11:27 AM Warner Losh wrote: > > Author: imp > Date: Fri Aug 7 16:26:56 2020 > New Revision: 364030 > URL: https://svnweb.freebsd.org/changeset/base/364030 > > Log: > The practice of creating symbolic links is somewhat fragile. Always > make copies instead. > > There's too many times that we can't run the new binaries with old > libraries. Making the links when things are known to be 'safe' is a > nice optimization, but a copy of all the binaries is only 30MB, so > saving the copies at the cost of increased support when new symbols > are added and used as part of the bootstrap seems to be unwise. > > There may be additional optimizations possible here, especially for > !FreeBSD hosts. However, that's beyond the scope of the problem I'm > trying to fix with make failing mid-way through an installworld across > change r363679. This optimization there caused us to run a new binary > with an old library once a new make was installed due to the symbolic > link. One could just copy make, but then other binaries fail as well, > so rather than play whack-a-mole, I opted to take us back to the old > way. Before r340157 or so we did copies (thogh of a lot fewer > artifacts), and we didn't have issues like this. > Many thanks for pinpointing the real cause here and solving it! Thanks, Kyle Evans