From owner-cvs-all@FreeBSD.ORG  Fri Dec 26 10:41:44 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D010216A4CE; Fri, 26 Dec 2003 10:41:44 -0800 (PST)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B98E943D1F; Fri, 26 Dec 2003 10:41:43 -0800 (PST)
	(envelope-from sam@errno.com)
Received: from 66.127.85.91 ([66.127.85.91])
	(authenticated bits=0)
	by ebb.errno.com (8.12.9/8.12.9) with ESMTP id hBQIfgHQ034664
	(version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO);
	Fri, 26 Dec 2003 10:41:43 -0800 (PST)
	(envelope-from sam@errno.com)
From: Sam Leffler <sam@errno.com>
Organization: Errno Consulting
To: "Brian F. Feldman" <green@FreeBSD.org>
Date: Fri, 26 Dec 2003 10:45:22 -0800
User-Agent: KMail/1.5.3
References: <200312261826.hBQIQkAX060681@green.bikeshed.org>
In-Reply-To: <200312261826.hBQIQkAX060681@green.bikeshed.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200312261045.22042.sam@errno.com>
cc: Brian Feldman <green@FreeBSD.org>
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/sys/net if.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Dec 2003 18:41:45 -0000

On Friday 26 December 2003 10:26 am, Brian F. Feldman wrote:
> Sam Leffler <sam@errno.com> wrote:
> > On Friday 26 December 2003 10:09 am, Brian Feldman wrote:
> > > green       2003/12/26 10:09:35 PST
> > >
> > >   FreeBSD src repository
> > >
> > >   Modified files:
> > >     sys/net              if.c
> > >   Log:
> > >   Don't truncate the interface name in ifunit().  It's now possible to
> > > query "very long interface names", e.g.:
> > >   ndis_atheros0:
> > > flags=8847<UP,BROADCAST,DEBUG,RUNNING,SIMPLEX,MULTICAST> mtu 1500
> >
> > I'm not sure this works out well as I believe user-level apps like
> > netstat assume interface names are short max-lengthed strings.  I've been
> > using the ndis stuff (great work btw) and was thinking instead that it
> > would be nice to customize the device by specifying the name at config
> > time.
> >
> > I think you need to discuss changes like this before committing them.
>
> They are still short max-length strings.  ifunit() wasn't accounting for
> the "dev/" it was appending when it searches for a given interface, so it
> was limiting things to IFNAMSIZE - 4 accidentally.

Sorry, I misunderstood your change and didn't look at the diff.

	Sam