From owner-freebsd-current@FreeBSD.ORG Sat Dec 13 20:36:27 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4DFF61065678 for ; Sat, 13 Dec 2008 20:36:27 +0000 (UTC) (envelope-from Tor.Egge@cvsup.no.freebsd.org) Received: from pil.idi.ntnu.no (pil.idi.ntnu.no [129.241.107.93]) by mx1.freebsd.org (Postfix) with ESMTP id C1C828FC13 for ; Sat, 13 Dec 2008 20:36:26 +0000 (UTC) (envelope-from Tor.Egge@cvsup.no.freebsd.org) Received: from cvsup.no.freebsd.org (c2h5oh.idi.ntnu.no [129.241.103.69]) by pil.idi.ntnu.no (8.14.1/8.13.1) with ESMTP id mBDK6tVX016031 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 13 Dec 2008 21:06:56 +0100 (MET) Received: from localhost (localhost [127.0.0.1]) by cvsup.no.freebsd.org (8.14.2/8.14.2) with ESMTP id mBDK6tpc038808; Sat, 13 Dec 2008 20:06:55 GMT (envelope-from Tor.Egge@cvsup.no.freebsd.org) Date: Sat, 13 Dec 2008 20:06:12 +0000 (UTC) Message-Id: <20081213.200612.74714794.Tor.Egge@cvsup.no.freebsd.org> To: glz@hidden-powers.com From: Tor Egge In-Reply-To: <088C87B70CB486D2F808091A@[10.255.253.2]> References: <088C87B70CB486D2F808091A@[10.255.253.2]> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="--Next_Part(Sat_Dec_13_20_06_12_2008_364)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned-By: mimedefang.idi.ntnu.no, using CLAMD X-SMTP-From: Sender=, Relay/Client=c2h5oh.idi.ntnu.no [129.241.103.69], EHLO=cvsup.no.freebsd.org X-Scanned-By: MIMEDefang 2.48 on 129.241.107.38 X-Scanned-By: mimedefang.idi.ntnu.no, using MIMEDefang 2.48 with local filter 16.42-idi X-Filter-Time: 1 seconds Cc: freebsd-current@freebsd.org, kmacy@freebsd.org Subject: Re: [PANIC] _rw_rlock (radix node head): wlock already held @ /usr/src/sys/net/route.c:291 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Dec 2008 20:36:27 -0000 ----Next_Part(Sat_Dec_13_20_06_12_2008_364)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit > I upgraded to CURRENT Dec 12 11pm and get this panic when ifconfig tries to > add an ipv6 route. I've gotten similar panics and am currently using the enclosed patch. - Tor Egge ----Next_Part(Sat_Dec_13_20_06_12_2008_364)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="rmx2.diff" Index: sys/netinet/in_rmx.c =================================================================== RCS file: /home/ncvs/src/sys/netinet/in_rmx.c,v retrieving revision 1.65 diff -u -r1.65 in_rmx.c --- sys/netinet/in_rmx.c 2 Dec 2008 21:37:28 -0000 1.65 +++ sys/netinet/in_rmx.c 13 Dec 2008 15:43:33 -0000 @@ -115,7 +115,7 @@ * ARP entry and delete it if so. */ rt2 = in_rtalloc1((struct sockaddr *)sin, 0, - RTF_CLONING, rt->rt_fibnum); + RTF_CLONING | RTF_RNH_LOCKED, rt->rt_fibnum); if (rt2) { if (rt2->rt_flags & RTF_LLINFO && rt2->rt_flags & RTF_HOST && Index: sys/netinet6/in6_rmx.c =================================================================== RCS file: /home/ncvs/src/sys/netinet6/in6_rmx.c,v retrieving revision 1.31 diff -u -r1.31 in6_rmx.c --- sys/netinet6/in6_rmx.c 8 Dec 2008 00:28:21 -0000 1.31 +++ sys/netinet6/in6_rmx.c 13 Dec 2008 19:51:18 -0000 @@ -160,7 +160,8 @@ * Find out if it is because of an * ARP entry and delete it if so. */ - rt2 = rtalloc1((struct sockaddr *)sin6, 0, RTF_CLONING); + rt2 = rtalloc1((struct sockaddr *)sin6, 0, + RTF_CLONING | RTF_RNH_LOCKED); if (rt2) { if (rt2->rt_flags & RTF_LLINFO && rt2->rt_flags & RTF_HOST && @@ -187,7 +188,8 @@ * net route entry, 3ffe:0501:: -> if0. * This case should not raise an error. */ - rt2 = rtalloc1((struct sockaddr *)sin6, 0, RTF_CLONING); + rt2 = rtalloc1((struct sockaddr *)sin6, 0, + RTF_CLONING | RTF_RNH_LOCKED); if (rt2) { if ((rt2->rt_flags & (RTF_CLONING|RTF_HOST|RTF_GATEWAY)) == RTF_CLONING ----Next_Part(Sat_Dec_13_20_06_12_2008_364)----