From owner-freebsd-current@freebsd.org Wed Feb 5 04:02:40 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9DEC623EE26 for ; Wed, 5 Feb 2020 04:02:40 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic305-19.consmr.mail.gq1.yahoo.com (sonic305-19.consmr.mail.gq1.yahoo.com [98.137.64.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48C7FC2T5vz42QW for ; Wed, 5 Feb 2020 04:02:38 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: NgbVQJwVM1mwxL5S5_Ym8_CpW_t2Ty4fT0AexMdggO85b4ZLbggang.N_UqFHhx 4pVVPQi_C2pvT5B3Zef8G.dulY0jFa9QSMBWmJQv2xxht10pXzqae2fUEr1c0IbD2UObGf3C1B_I BrU.Q6ZN9se9jiF9ckke_fMSlpyqYdV4mX0_rc5C9_59j7ozXE7K1poYWFhKCJae8TeGEB9LnRMf hqDwSE5sIQgqM8s4AwiGjEUsLT7zGQYRLe2k9KfT.CRGhvrGAotKRj4TP6H8VCSfmzX4IHpy0rfW cSCMKV24yKnKVLnMJw_zkSt7ddqUcuVVcBaBQk1buoDpSMg7SSF2.jGqFwTWgd8U9RL20UuKqzy9 g_LTAVb.IGzKFcTGRF.XcRhAYPqoCQrPXhmmb2E2ntAUqLJ4oTjMJIpSdC4o0A1N9ovgYcfSWSWn TM20lrmgce_nzmHYqvKrPtznnNjMCBLY_y1F7FyD8a33kRRXCaDfCgGzFKL8TrhqtmoyMV3rC6t9 w13.isVL4lCDl9WivNwhY8QoRmK.C5.5F0HTO5ZRsnoNlTPDhu1sYAZ0_0HxAXPo7Jp14Gr3G054 2EQ7A..Ze450jYDg7xfJA62UyDQgpTH7RcrulX3tacg9Gg.OfngY_vMfkpcG1xAofWouRQ5S58Jt FfG4PBEVSYDKWyybwMDPOKs4qg9Ck9NufV8xIO3K5sV.cibe4KlzD6wSqB0Kz8.Y.4XCA9_wxjsx XEJhTj2Ba3VLGj6kOIqjD1ks.e22JZcpt0yC2GKwKiUijsGJr1NpvumUPLpX4fyXt.oCYE4DNVoZ 9GiIkJgewclBbGH84IsH2qhL98Wwd9evRHBtrtDu8xfnqvtqd5qN.dB1bQ.Z6hkde32pREBw7nSa 2Tofl7Fe55ALTvqIZz3Wjnoj_tSn6OjOnJQjXYR5ef7DhKPJoMz_NUlePP8owHiIOxljDQyLwlsI Opytrb85pY0v.cwpOJohNXZhFTe.dCmZnfuH5aqWsU8cp633IT10hn6GEUsOmPfM1G64Kt8MFKyC wdwh.eQblaxx0D7VfwlzElvDaNy4KxLPpUWtqbGHOF4T_1.9FgspNk5jD2DdGl65bmePv7pwwUzi kWPOkJ420Q7bi4vTqnJmr60YcTFVZcgwFdc1cX5w4UGSR6tJnEJNgqGmI3KZ46agFRm8yF9qy9i2 LMRzphmkmnMiC3EYj9vL_w5FxGvtbZJIKc64IZgKTGZ4xc1foCsEWC5pXNs64EUsQawdVCftGST_ A.dPzEar1zT8RYabMuE6uzEy6bSQmXIvLMlCCsrBzXwxOZVpYaKVKUxDPYYK9mJT0XkB_wOq9U7X rf8DCpqIJxMyVoRrFZXqi_V7AgWakw1ygSEA9C54llargq52XevLFeAEHhLX8lPUmXf_5j_th9bT QexBhW29tyn7z5kGNHCE_Gr1Lxz3YcqwaNDGiMBWCcNMbuBVsR0CJibYpNttBXq4rrGkteA-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.gq1.yahoo.com with HTTP; Wed, 5 Feb 2020 04:02:37 +0000 Received: by smtp407.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID a3b441192117e3dfb4dde7bb72097098; Wed, 05 Feb 2020 04:02:31 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Subject: artifact.ci's head -r357545 kernel for 32-bit powerpc FreeBSD vs. 64-bit PowerMac: panic: lock tfo_ccache_bucket . . . already initialized Message-Id: <6CCBEDA2-AB51-4C2C-8C7F-1F985B19B021@yahoo.com> Date: Tue, 4 Feb 2020 20:02:31 -0800 To: FreeBSD PowerPC ML , FreeBSD Current X-Mailer: Apple Mail (2.3608.60.0.2.5) References: <6CCBEDA2-AB51-4C2C-8C7F-1F985B19B021.ref@yahoo.com> X-Rspamd-Queue-Id: 48C7FC2T5vz42QW X-Spamd-Bar: - X-Spamd-Result: default: False [-1.03 / 15.00]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.33)[-0.330,0]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-0.20)[-0.198,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (5.62), ipnet: 98.137.64.0/21(0.83), asn: 36647(0.66), country: US(-0.05)]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[82.64.137.98.list.dnswl.org : 127.0.5.0]; RWL_MAILSPIKE_POSSIBLE(0.00)[82.64.137.98.rep.mailspike.net : 127.0.0.17]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Feb 2020 04:02:40 -0000 On a 32-bit PowerMac 2 socket machine, it booted just fine. This is a 64-bit capable 2 socket, 2 cores each, PowerMac context for the example failure. There is also an odd "kern.ipc.nmbclusters limit reached" message before the powerpc64 panic. Typed from a picture of the screen: (I omit stack addresses and routine offsets in the backtrace.) . . . firewire0: bus manager 1 bge0: link state changed to UP [zone: mbuf_cluster] kern.ipc.nmbclusters limit reached panic: lock "tfo_ccache_bucket" 0xdd533f24 already initialized cpuid =3D 0 time =3D 1 KDB: stack backtrace . . . panic lock_init _mtx_init tcp_fastopen_init tcp_init protosw_init vnet_domain_init vnet_register_sysinit mi_startup btext KDB: enter: panic [ thread pid 0 tid 100000 ] . . . This is too early for user input to the db> prompt on PowerMacs. The loop in tcp_fastopen_init(void) seems to be: for (i =3D 0; i < V_tcp_fastopen_ccache.buckets; i++) { TAILQ_INIT(&V_tcp_fastopen_ccache.base[i].ccb_entries); mtx_init(&V_tcp_fastopen_ccache.base[i].ccb_mtx, = "tfo_ccache_bucket", NULL, MTX_DEF); if (V_tcp_fastopen_client_enable) { /* enable bucket */ V_tcp_fastopen_ccache.base[i].ccb_num_entries =3D = 0; } else { /* disable bucket */ V_tcp_fastopen_ccache.base[i].ccb_num_entries =3D = -1; } V_tcp_fastopen_ccache.base[i].ccb_ccache =3D = &V_tcp_fastopen_ccache; } Separately, the warning: [zone: mbuf_cluster] kern.ipc.nmbclusters limit reached also seems odd. The powerpc64 FreeBSD variant does not get this message. It leaves me wondering if the 32-bit FreeBSD atomic_fetchadd_64 and smp_started cross-socket/cross-core value synchronization are working fully-correctly on 64-bit PowerMacs. However, I'm outside of my area, so take the below on such a basis. It does appear to me that the SMP case for the !smp__started yet context does not have code for s=3Dintr_disable() and intr_restore(s) . (Not limited to atomic_fetchadd_64.) Such disable/restore code is only present for the !SMP case. How strongly is the !smp_started temporary-context like the !SMP case as far as what it requires for correctness? FYI: 008fc99c mflr r0 008fc9a0 stw r0,4(r1) 008fc9a4 stwu r1,-32(r1) 008fc9a8 stw r31,28(r1) 008fc9ac stw r30,24(r1) 008fc9b0 mr r31,r1 008fc9b4 stw r26,8(r31) 008fc9b8 stw r27,12(r31) 008fc9bc stw r28,16(r31) 008fc9c0 stw r29,20(r31) 008fc9c4 bl 008fc9c8 = 008fc9c8 mr r27,r3 008fc9cc mflr r30 008fc9d0 addis r30,r30,80 008fc9d4 addi r30,r30,8180 008fc9d8 mr r28,r6 008fc9dc mr r3,r27 008fc9e0 mr r29,r5 008fc9e4 bl 0093e668 008fc9e8 lwz r4,-32768(r30) 008fc9ec rlwinm r3,r3,25,24,31 008fc9f0 mulli r26,r3,20 008fc9f4 lwz r4,0(r4) 008fc9f8 cmplwi r4,0 008fc9fc beq- 008fca1c = 008fca00 lwz r3,-32764(r30) 008fca04 lwz r5,-32760(r30) 008fca08 li r4,0 008fca0c li r6,101 008fca10 add r3,r3,r26 008fca14 addi r3,r3,16 008fca18 bl 0051b0b0 <__mtx_lock_flags> 008fca1c lwz r3,4(r27) 008fca20 lwz r4,0(r27) 008fca24 addc r3,r3,r28 008fca28 stw r3,4(r27) 008fca2c adde r3,r4,r29 008fca30 stw r3,0(r27) 008fca34 lwz r3,-32768(r30) 008fca38 lwz r4,4(r27) 008fca3c lwz r5,0(r27) 008fca40 lwz r3,0(r3) 008fca44 subfc r28,r28,r4 008fca48 subfe r29,r29,r5 008fca4c cmplwi r3,0 008fca50 beq- 008fca70 = 008fca54 lwz r3,-32764(r30) 008fca58 lwz r5,-32760(r30) 008fca5c li r4,0 008fca60 li r6,101 008fca64 add r3,r3,r26 008fca68 addi r3,r3,16 008fca6c bl 0051b780 <__mtx_unlock_flags> 008fca70 mr r3,r29 008fca74 mr r4,r28 008fca78 lwz r29,20(r31) 008fca7c lwz r28,16(r31) 008fca80 lwz r27,12(r31) 008fca84 lwz r26,8(r31) 008fca88 lwz r0,36(r1) 008fca8c lwz r31,28(r1) 008fca90 lwz r30,24(r1) 008fca94 addi r1,r1,32 008fca98 mtlr r0 008fca9c blr =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)