From owner-cvs-all  Wed Jan 15 15:50:57 2003
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E67D537B401; Wed, 15 Jan 2003 15:50:55 -0800 (PST)
Received: from espresso.q9media.com (espresso.q9media.com [65.39.129.122])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 895FF43ED8; Wed, 15 Jan 2003 15:50:52 -0800 (PST)
	(envelope-from mike@espresso.q9media.com)
Received: by espresso.q9media.com (Postfix, from userid 1002)
	id E03AE9C10; Wed, 15 Jan 2003 18:39:43 -0500 (EST)
Date: Wed, 15 Jan 2003 18:39:43 -0500
From: Mike Barcroft <mike@FreeBSD.org>
To: Johan Karlsson <johan@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libc/stdlib realpath.3 realpath.c src/bin/realpath realpath.c
Message-ID: <20030115183943.D58850@espresso.q9media.com>
References: <200301152122.h0FLMtdE034299@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200301152122.h0FLMtdE034299@repoman.freebsd.org>; from johan@FreeBSD.org on Wed, Jan 15, 2003 at 01:22:55PM -0800
Organization: The FreeBSD Project
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Johan Karlsson <johan@FreeBSD.org> writes:
> johan       2003/01/15 13:22:55 PST
> 
>   Modified files:
>     lib/libc/stdlib      realpath.3 realpath.c 
>     bin/realpath         realpath.c 
>   Log:
>   realpath(3) should use PATH_MAX instead of MAXPATHLEN according to POSIX.
>   
>   This also reverts the PATH_MAX -> MAXPATHLEN part of
>   rev 1.3 of src/bin/realpath/realpath.c
>   
>   Requested by:   imp
>   Reviewed by:    imp, bde
>   
>   Revision  Changes    Path
>   1.5       +1 -1      src/bin/realpath/realpath.c
>   1.12      +2 -2      src/lib/libc/stdlib/realpath.3
>   1.12      +7 -7      src/lib/libc/stdlib/realpath.c

Hmm, I thought it was more complicated than this.  IIRC, PATH_MAX
isn't necessarily available at compile-time, so it needs more
complications to conform to POSIX in the case where PATH_MAX isn't
defined.  Portablility might not be important, in which case it
isn't clear why we would change from MAXPATHLEN to PATH_MAX or vice
versa.

Best regards,
Mike Barcroft

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message