From owner-svn-src-head@freebsd.org Thu Sep 1 13:42:05 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A8472BCAF78; Thu, 1 Sep 2016 13:42:05 +0000 (UTC) (envelope-from marieheleneka@gmail.com) Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3FA14F7; Thu, 1 Sep 2016 13:42:05 +0000 (UTC) (envelope-from marieheleneka@gmail.com) Received: by mail-wm0-x230.google.com with SMTP id v143so22545825wmv.0; Thu, 01 Sep 2016 06:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yiPbxLlIQQDQiUdkksmqumZZJxoIdtEKabpmVvXMm9g=; b=nW3eCJdnrDqrOgqyW+LJxX/TXEK7YOQRb/jE3gQLZucseTlWfJy+ZxQ8wMaMdzS9Ua q3wlEUQ8CZYuUo/sLDdG4i7NY85+yZVJCdGwRylnAggMWNsx4LbB0yuD48blZlEPnbPg nRE5/nVNitCOpCSfuqBB501K7FkdL7JWePtyQswOZJjhYNjetHTvFGwZIw4OpF48b6H5 ds2mo+m1kB0rCBJSOfCzm3aIsjcjYp2+IMMrthIsmpywTNZVYJA/UEr/JO14Ti+ycWEx XXb+tbCxgMGpWUbaCrXtJlOxAwllPrE8xl3lbBrbaCHNTjUklygXsi2xswbDjpSBAtsf uvnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yiPbxLlIQQDQiUdkksmqumZZJxoIdtEKabpmVvXMm9g=; b=lmYkf+3+9Rr0Eqau9rtKiclMkMkg+x6NLXz1bt+jnkaZi8ojM7bff6CE/RmZ+z61pg rj08PW+h+HQc13VCvT/EmaN/5ZvpT1Ulha0JxM+hDVSt3OZ1H/jLHe+XCyMh3WmOFC/L UmAK9TnWvlWXBO/LiPsaRv/6cf7rwJL2nQJ++K/rX3Sg/Lxb43eG8LxI58aoqyWUUejS sfv/dKvnJXsasvTuNvKqPMq6ff5ssC4z+l9L15HfYOqVAvUOAEWvrAH6ZytiyJXT/VCp ADosPCJtveu0YeoEsWL9gtQ3hWOZSahVVGsq7o7NnIZq3n+qWNVozJkYeOftswb0i36J Ruug== X-Gm-Message-State: AE9vXwPiJEA1xc+a5XV8v4g8Zvs1kE2/JeXWFYgwC53U3Fkx8uY7+CFRfP9z6/GZwp0a5pvxyebl06cl24P+tg== X-Received: by 10.194.133.104 with SMTP id pb8mr14320245wjb.139.1472737321460; Thu, 01 Sep 2016 06:42:01 -0700 (PDT) MIME-Version: 1.0 References: <201608251940.u7PJePv3023083@repo.freebsd.org> <23395083.lPEyYQ7ZbW@ralph.baldwin.cx> <1A050E0F-4B9F-420A-97C6-C203B92A5F3F@FreeBSD.org> <20160825203014.GB5517@FreeBSD.org> In-Reply-To: <20160825203014.GB5517@FreeBSD.org> From: Marie Helene Kvello-Aune Date: Thu, 01 Sep 2016 13:41:50 +0000 Message-ID: Subject: Re: svn commit: r304815 - in head: lib lib/libifc share/examples/libifc share/mk To: Alexey Dokuchaev , Kristof Provost Cc: John Baldwin , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Sep 2016 13:42:05 -0000 On Thu, Aug 25, 2016 at 10:30 PM Alexey Dokuchaev wrote: > On Thu, Aug 25, 2016 at 10:20:29PM +0200, Kristof Provost wrote: > > On 25 Aug 2016, at 22:14, John Baldwin wrote: > > > I hate even writing this mail, and it looks like the topic wasn't > > > really discussed in the review, but I think libifconfig is probably > > > the "better" name if the goal is to move most of ifconfig into it. > > > ... > > > Hmm, it seems you are 'libifc_*'. Most of our libraries do not > > > include 'lib' in the namespace prefix (see above examples that all > > > use the name of the library without 'lib' as the prefix). If nothing > > > else I'd suggest dropping 'lib' to be consistent with most other > > > libraries in the tree. > > +1. > > > The name was in fact discussed privately, and we figured libifconfig > > was a bit on the long side. > > Oh come one, we already have `libblocksruntime' and `libbluetooth' (and > some others I probably don't remember now). `libifconfig' is just fine. > Potential namespace clashes are a lot nastier than a longer name. > > > I certainly take your point about libifc_. Does anyone else have any > > views regarding the naming (or other subjects)? > > I second John, dropping the `lib' prefix and going with `ifconfig_' looks > like a good idea. > > ./danfe > Considering the points raised on this topic, I agree naming it 'libifconfig' and using 'ifconfig_' prefix is better than what's currently in place. I've submitted a differential revision for it here: https://reviews.freebsd.org/D7742 This should be committed before further fixes, to keep as much history as possible. Regards, Marie Helene