From owner-freebsd-stable@FreeBSD.ORG Mon Apr 14 12:23:45 2003 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 364CF37B401 for ; Mon, 14 Apr 2003 12:23:45 -0700 (PDT) Received: from mail.gactr.uga.edu (mail.gactr.uga.edu [128.192.37.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id 17BCF43FA3 for ; Mon, 14 Apr 2003 12:23:43 -0700 (PDT) (envelope-from Robin.Blanchard@gactr.uga.edu) Received: (qmail 41074 invoked from network); 14 Apr 2003 19:23:42 -0000 Received: from unknown (HELO ex.gactr.uga.edu) ([10.10.11.21]) (envelope-sender ) by mail.servers.gactr.gc.nat (qmail-ldap-1.03) with SMTP for ; 14 Apr 2003 19:23:42 -0000 Content-Class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-MimeOLE: Produced By Microsoft Exchange V6.0.6375.0 Date: Mon, 14 Apr 2003 15:23:42 -0400 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: Ipf headers not installed per default ? Thread-Index: AcMCuGNyjjTbnH6xRYGFW3ymODXuPgAAf9sg From: "Robin P. Blanchard" To: "Crist J. Clark" cc: stable@freebsd.org cc: adrian@freebsd.org Subject: RE: Ipf headers not installed per default ? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Apr 2003 19:23:45 -0000 > > The configure script does not locate IPF's header files. I had to=20 > > manually copy them over: # cp -p=20 > > /usr/src/sys/contrib/ipfilter/netinet/*.h /usr/include/netinet/ > >=20 > > Squid then built fine. Should these header files be=20 > installed with the=20 > > world? Or should squid's port be modified to include=20 > > /usr/src/sys/include/ipfilter ? >=20 > It shouldn't look in /usr/src. Ports should (a) not expect=20 > the user to have a FreeBSD source tree or (b) demand that it=20 > be in /usr/src (although you could add a make variable that=20 > is the base of the source tree that defaults to /usr/src, if=20 > there isn't one already). >=20 > The IPFilter .h-files should be installed with world. Whether=20 > they belong in /usr/include/netinet or somewhere else is a=20 > different matter. Without digging into the CVS repo, I'd=20 > venture to guess that this happened when IPFitler files got=20 > separated out of the src/sys tree into src/sys/contrib/ipfilter. >=20 > Why don't you send in a PR on this? Thanks for jogging my mind on this...Now that you've brought that up, I = can see that on a -STABLE ipf box that's been around for quite some time = (and on which the squid port worked without 'hacking'): # [/usr/src/sys/contrib/ipfilter/netinet]# for i in *.h ; do find /usr/include/netinet/$i -exec ls -ald {} \;; done =20 -r--r--r-- 1 root wheel 1564 May 10 2002 = /usr/include/netinet/ip_auth.h -r--r--r-- 1 root wheel 34148 May 10 2002 /usr/include/netinet/ip_compat.h -r--r--r-- 1 root wheel 21840 May 10 2002 = /usr/include/netinet/ip_fil.h -r--r--r-- 1 root wheel 1905 May 10 2002 = /usr/include/netinet/ip_frag.h -r--r--r-- 1 root wheel 8826 May 10 2002 = /usr/include/netinet/ip_nat.h -r--r--r-- 1 root wheel 4559 May 10 2002 = /usr/include/netinet/ip_proxy.h -r--r--r-- 1 root wheel 5621 May 10 2002 = /usr/include/netinet/ip_state.h -r--r--r-- 1 root wheel 324 May 10 2002 /usr/include/netinet/ipl.h Whereas on a newer -STABLE box: # [/usr/src/sys/contrib/ipfilter/netinet]# for i in *.h ; do find /usr/include/netinet/$i -exec ls -ald {} \;; done=20 find: /usr/include/netinet/ip_auth.h: No such file or directory find: /usr/include/netinet/ip_compat.h: No such file or directory find: /usr/include/netinet/ip_fil.h: No such file or directory find: /usr/include/netinet/ip_frag.h: No such file or directory find: /usr/include/netinet/ip_nat.h: No such file or directory find: /usr/include/netinet/ip_proxy.h: No such file or directory find: /usr/include/netinet/ip_state.h: No such file or directory find: /usr/include/netinet/ipl.h: No such file or directory