From nobody Mon Jun 23 16:30:21 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bQtq50l9vz60VrP; Mon, 23 Jun 2025 16:30:25 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta004.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bQtq458pvz4CYL; Mon, 23 Jun 2025 16:30:24 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTPS id TfuBuTopv5MqyTk3ruu4IG; Mon, 23 Jun 2025 16:30:23 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id Tk3qujh1YJhBPTk3rux2nj; Mon, 23 Jun 2025 16:30:23 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=QY3Fvdbv c=1 sm=1 tr=0 ts=6859811f a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=YxBL1-UpAAAA:8 a=VanQiltTAeBbaUYDtakA:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id EF390199; Mon, 23 Jun 2025 09:30:21 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (Postfix) with ESMTP id B603E15F; Mon, 23 Jun 2025 09:30:21 -0700 (PDT) Date: Mon, 23 Jun 2025 09:30:21 -0700 From: Cy Schubert To: Dima Panov Cc: Cy Schubert , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 7e35117eb07f - main - Makefile: Hook MIT KRB5 into the build Message-ID: <20250623093010.71b18c87@slippy> In-Reply-To: <3742e37c-bca9-4778-881a-94c09aefdb32@FreeBSD.org> References: <202506160251.55G2pwx4063231@gitrepo.freebsd.org> <20250620073050.7f03f74e@slippy> <3742e37c-bca9-4778-881a-94c09aefdb32@FreeBSD.org> Organization: KOMQUATS X-Mailer: Claws Mail 3.21.0 (GTK+ 2.24.33; amd64-portbld-freebsd15.0) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfMG3UqRDib59CrLPQQ/QqbIXW2ya6cTXQTTR/r+xeyJEMK+zf4NY+AkGa+fwyvWRsPZZW0k36xyC87XLg7blu3uZ/d0wtxjjPt39BcJeStq2cQSQS3k+ tLJJgWCnV5Z9il+k3xHAruhNZ3Z5TXAMBLQEfzRtGrt+9HOQAwLUem2sn4tHdd3wlBXWBTeJoct57uHNN4ayXA+KXwY5dJTRbFVi3exjpax1j5TmNRePKQh8 XFYdqG2bpeKGmkhYN85lz29tiBrvX4aME7Dc9lqU4RrxlxpjH0BSDtN9TWwWAsQKvnmD7JgTQtYVhy/EUMksrCpRPFUceuiji8jhnpgSXZdykMvPv4IV6s8b HH2W/S6B X-Rspamd-Queue-Id: 4bQtq458pvz4CYL X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] Thanks for pointing this out. This has been addressed. We will forego the warning as upstream doesn't include a warning. I prefer to let upstream decide whether to display a warning. Your testing is muchly appreciated. Is this work part of portmgr's exp-run? -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e**(i*pi)+1=0 On Mon, 23 Jun 2025 01:19:52 +0300 Dima Panov wrote: > Hello! > > > BTW, another suggestion, as follow-up solution already exist in security/krb5-* ports. > provide compat shim /usr/include/krb5.h with next content: > > #include > > May be also add guard warning as it was done for gssapi.h: > #ifdef __GNUC__ > #warning "this file includes which is deprecated, use instead" > #endif > > > On 20.06.2025 17:30, Cy Schubert wrote: > > On Fri, 20 Jun 2025 12:27:09 +0300 > > Dima Panov wrote: > > > >> Hello! > >> > >> > >> Looks like something missing after the build with MIT Kerberos. > >> > >> got this with devel/gvfs build: > >> > >> == > >> In file included from ../daemon/pty_open.c:70: > >> /usr/include/util.h:36:10: fatal error: 'k5-int.h' file not found > >> 36 | #include "k5-int.h" > >> | ^~~~~~~~~~ > >> 1 error generated. > >> == > >> > >> Indeed, k5-int.h is missing in /usr/include :( > >> > >> On 16.06.2025 05:51, Cy Schubert wrote: > >>> The branch main has been updated by cy: > >>> > >>> URL: https://cgit.FreeBSD.org/src/commit/?id=7e35117eb07f86c385656ecc6a2a92093be98131 > >>> > >>> commit 7e35117eb07f86c385656ecc6a2a92093be98131 > >>> Author: Cy Schubert > >>> AuthorDate: 2025-06-11 02:57:54 +0000 > >>> Commit: Cy Schubert > >>> CommitDate: 2025-06-16 02:49:37 +0000 > >>> > >>> Makefile: Hook MIT KRB5 into the build > >>> > >>> Add tests for MK_MITKRB5. If "yes" build MIT KRB5. If "no" build Heimdal. > >>> The default is MK_MITKRB5 = no, added by "krb5: Add build plumbing". > >>> > >>> At some point we will change the default to MK_MITKRB5 = yes. A ports > >>> exp-run will need to be successfully run first. > >>> > >>> Sponsored by: The FreeBSD Foundation > >>> Differential revision: https://reviews.freebsd.org/D50815 > >>> --- > >>> Makefile.inc1 | 89 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > >>> Makefile.libcompat | 4 +++ > >>> tools/build/Makefile | 64 +++++++++++++++++++++++++++++++++++++ > >>> 3 files changed, 157 insertions(+) > >>> > > [...] > > > > The attached patch will fix the problem. It contains two parts. > > > > 1. Don't install the offending header files. They were in my first cut > > of the plugins build and were not removed as I cleaned up while > > rationalizing the installed files with the port. > > > > 2. OptionalObsoleteFiles.inc removes the files that were erroneously > > installed. > > > > It is enough to run make delete-old to fix the problem. The Maefile > > patch ensures they're not installed again. > > > > My buildworld/installworld test is still running to verify nothing else > > is broken. > > > > Sorry for the breakage. > > >