From owner-freebsd-pf@FreeBSD.ORG Thu Sep 16 04:02:07 2004 Return-Path: Delivered-To: freebsd-pf@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 674) id C1D8E16A4CF; Thu, 16 Sep 2004 04:02:07 +0000 (GMT) Delivered-To: mlaier@vampire.homelinux.org Received: (qmail 37547 invoked by uid 1005); 24 Feb 2004 00:40:33 -0000 Delivered-To: max@vampire.homelinux.org Received: (qmail 37544 invoked from network); 24 Feb 2004 00:40:33 -0000 Received: from moutng.kundenserver.de (212.227.126.188) by p50839aba.dip.t-dialin.net with SMTP; 24 Feb 2004 00:40:33 -0000 Received: from [212.227.126.153] (helo=mxng02.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1AvQYa-0001HI-00 for max@vampire.homelinux.org; Tue, 24 Feb 2004 01:36:16 +0100 Received: from [206.53.239.180] (helo=turing.freelists.org) by mxng02.kundenserver.de with esmtp (Exim 3.35 #1) id 1AvQYa-0007Ei-00 for max@love2party.net; Tue, 24 Feb 2004 01:36:16 +0100 Received: from turing (localhost [127.0.0.1])ESMTP id E08EE3950A6; Mon, 23 Feb 2004 19:33:44 -0500 (EST) Received: with ECARTIS (v1.0.0; list pf4freebsd); Mon, 23 Feb 2004 19:33:32 -0500 (EST) X-Original-To: pf4freebsd@freelists.org Delivered-To: pf4freebsd@freelists.org Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.186])ESMTP id B0CAF395062 for ; Mon, 23 Feb 2004 19:33:30 -0500 (EST) Received: from [212.227.126.205] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1AvQYK-0007Su-00 for pf4freebsd@freelists.org; Tue, 24 Feb 2004 01:36:00 +0100 Received: from [80.131.154.186] (helo=vampire.homelinux.org) by mrelayng.kundenserver.de with asmtp (Exim 3.35 #1) id 1AvQYK-0003JZ-00 for pf4freebsd@freelists.org; Tue, 24 Feb 2004 01:36:00 +0100 Received: (qmail 37540 invoked from network); 24 Feb 2004 00:40:15 -0000 Received: from unknown (HELO fbsd52.laiers.local) (192.168.4.88) by 192.168.4.1 with SMTP; 24 Feb 2004 00:40:15 -0000 From: Max Laier To: pf4freebsd@freelists.org, Andrew Thompson User-Agent: KMail/1.5.4 References: <20040224001503.GA99464@kate.fud.org.nz> In-Reply-To: <20040224001503.GA99464@kate.fud.org.nz> MIME-Version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Disposition: inline Message-Id: <200402240135.55752.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:e28873fbe4dbe612ce62ab869898ff08 X-archive-position: 282 X-ecartis-version: Ecartis v1.0.0 Sender: pf4freebsd-bounce@freelists.org Errors-To: pf4freebsd-bounce@freelists.org X-original-sender: max@love2party.net Precedence: normal X-list: pf4freebsd Content-Transfer-Encoding: quoted-printable X-Provags-Forward: max@love2party.net -> max@vampire.homelinux.org X-UID: 400 X-Length: 3745 X-Mailman-Approved-At: Thu, 16 Sep 2004 04:04:15 +0000 Subject: [pf4freebsd] Re: pfflowd port X-BeenThere: freebsd-pf@freebsd.org X-Mailman-Version: 2.1.1 Reply-To: pf4freebsd@freelists.org List-Id: Technical discussion and general questions about packet filter (pf) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Thu, 16 Sep 2004 04:02:07 -0000 X-Original-Date: Tue, 24 Feb 2004 01:35:55 +0100 X-List-Received-Date: Thu, 16 Sep 2004 04:02:07 -0000 On Tuesday 24 February 2004 01:15, Andrew Thompson wrote: > Hi all, > > I have created a port for pfflowd and thought i'd get feedback before > submitting a PR. > > It can be found @ > > http://www.fud.org.nz/pfflowd-port.tar.gz Okay, some feedback: 1) You copied from security/pf (which is okay), but you should update the= =20 pkg-descr. 2) pkg-plist is empty, but should contain: sbin/pfflowd etc/rc.d/pfflowd.sh.sample 3) Not sure what the patch for pfflowd.c should do. What is wrong with th= e=20 check for invalid ports? 4) Maybe get the pidfile.{c,h} from us (include/support/) and add them=20 instead of just removing and pidfile support. --=20 Best regards, | mlaier@freebsd.org Max Laier | ICQ #67774661 http://pf4freebsd.love2party.net/ | mlaier@EFnet