From owner-svn-src-all@FreeBSD.ORG Sun Apr 3 16:16:53 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6ACF4106566B; Sun, 3 Apr 2011 16:16:53 +0000 (UTC) (envelope-from emaste@freebsd.org) Received: from mail1.sandvine.com (Mail1.sandvine.com [64.7.137.134]) by mx1.freebsd.org (Postfix) with ESMTP id 210808FC17; Sun, 3 Apr 2011 16:16:53 +0000 (UTC) Received: from labgw2.phaedrus.sandvine.com (192.168.222.22) by WTL-EXCH-1.sandvine.com (192.168.196.31) with Microsoft SMTP Server id 14.0.694.0; Sun, 3 Apr 2011 12:06:02 -0400 Received: by labgw2.phaedrus.sandvine.com (Postfix, from userid 10332) id 403F633C00; Sun, 3 Apr 2011 12:06:02 -0400 (EDT) Date: Sun, 3 Apr 2011 12:06:02 -0400 From: Ed Maste To: "Bjoern A. Zeeb" Message-ID: <20110403160602.GA67576@sandvine.com> References: <201103300119.p2U1J18L046334@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Ed Maste Subject: Re: svn commit: r220153 - head/etc/rc.d X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Apr 2011 16:16:53 -0000 On Sun, Apr 03, 2011 at 02:56:50PM +0000, Bjoern A. Zeeb wrote: > On Wed, 30 Mar 2011, Ed Maste wrote: > > Replace ${SYSCTL_W} with ${SYSCTL} in rc.d scripts, as they are identical. > > ... for example OSX really requires the -w to alter a > sysctl while we permit without. I thin kthe correct fix should have > been to add a -w to SYSCTL_W. NetBSD also requires -w as far as I know. However, we've deprecated the switch -- see sysctl(8): The -w option has been deprecated and is silently ignored. I don't think there's much value in using a deprecated and ignored flag in our startup scripts. > That way one can grep for a read vs. > write in the startup scrpits a lot more easily, etc. Something along the lines of egrep -ir 'sysctl.*=' can be used to find places that sysctls are written; this has the benefit of finding the cases where we're already not using a ${SYSCTL} or ${SYSCTL_W} variable today. -Ed