From owner-svn-src-head@freebsd.org  Tue Mar  7 22:17:36 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 485B6D025BD;
 Tue,  7 Mar 2017 22:17:36 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (glebi.us [96.95.210.25])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 32E401DF0;
 Tue,  7 Mar 2017 22:17:35 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id v27MHXQm095014
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Tue, 7 Mar 2017 14:17:33 -0800 (PST)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id v27MHXbx095013;
 Tue, 7 Mar 2017 14:17:33 -0800 (PST)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Tue, 7 Mar 2017 14:17:33 -0800
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Andriy Gapon <avg@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r314862 - head/sys/modules/qlxgbe
Message-ID: <20170307221733.GN1044@FreeBSD.org>
References: <201703071543.v27FhnoL024242@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201703071543.v27FhnoL024242@repo.freebsd.org>
User-Agent: Mutt/1.7.2 (2016-11-26)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Mar 2017 22:17:36 -0000

On Tue, Mar 07, 2017 at 03:43:49PM +0000, Andriy Gapon wrote:
A> Author: avg
A> Date: Tue Mar  7 15:43:49 2017
A> New Revision: 314862
A> URL: https://svnweb.freebsd.org/changeset/base/314862
A> 
A> Log:
A>   qlxgbe: add GCC_MS_EXTENSIONS to CFLAGS to make old base GCC happy
A>   
A>   The module uses unnamed structure and union fields and base GCC in
A>   stable/10 doesn't like it.
A>   I think that that is a C11 feature, so it is courteous of more modern
A>   compilers to not complain about it when compiling in C99 mode.

There are a lot of code in kernel, that uses anonymous structs and unions.
This feature is enabled globally. Why does this module need special treatment?

-- 
Totus tuus, Glebius.