From owner-svn-src-all@freebsd.org Thu Dec 1 20:43:41 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A8D60C6067D; Thu, 1 Dec 2016 20:43:41 +0000 (UTC) (envelope-from gonzo@id.bluezbox.com) Received: from id.bluezbox.com (id.bluezbox.com [45.55.20.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 869A31EC1; Thu, 1 Dec 2016 20:43:41 +0000 (UTC) (envelope-from gonzo@id.bluezbox.com) Received: from [208.184.220.60] (helo=nmamm-mbp2.dolby.net) by id.bluezbox.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87 (FreeBSD)) (envelope-from ) id 1cCYCe-000OYr-IW; Thu, 01 Dec 2016 12:43:40 -0800 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.1 \(3251\)) Subject: Re: svn commit: r309368 - stable/11/sys/boot/zfs From: Oleksandr Tymoshenko In-Reply-To: <75AD339A-FECF-4C82-ADF1-FACDF0FDD2B6@me.com> Date: Thu, 1 Dec 2016 12:43:05 -0800 Cc: Toomas Soome , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201612011906.uB1J69XK076481@repo.freebsd.org> <186048AF-0A74-4DCD-8A54-1DCE26CCE9D3@bluezbox.com> <75AD339A-FECF-4C82-ADF1-FACDF0FDD2B6@me.com> To: Toomas Soome X-Mailer: Apple Mail (2.3251) Sender: gonzo@id.bluezbox.com X-Spam-Level: -- X-Spam-Report: Spam detection software, running on the system "id.bluezbox.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see The administrator of that system for details. Content preview: > On Dec 1, 2016, at 12:34 PM, Toomas Soome wrote: > > >> On 1. dets 2016, at 22:01, Oleksandr Tymoshenko wrote: >> >> >>> On Dec 1, 2016, at 11:06 AM, Toomas Soome wrote: >>> >>> Author: tsoome >>> Date: Thu Dec 1 19:06:09 2016 >>> New Revision: 309368 >>> URL: https://svnweb.freebsd.org/changeset/base/309368 >>> >>> Log: >>> MFC r308776 >>> >>> loader: zfs toplevel vdev must have spa set. >>> >>> PR: 214375 >>> Reported by: lstewart >>> Reviewed by: allanjude, imp >>> Approved by: allanjude (mentor), imp (mentor) >>> Differential Revision: https://reviews.freebsd.org/D8487 >> >> Hi Tom, >> >> Looks like this commit breaks the build: >> >> In file included from /src/FreeBSD/11/sys/boot/efi/loader/../../zfs/zfs.c:49: >> /src/FreeBSD/11/sys/boot/efi/loader/../../zfs/zfsimpl.c:1021:13: error: no membe >> r named 'spa' in 'struct vdev' >> top_vdev->spa = spa; >> ~~~~~~~~ ^ >> >> >> > > Yes, I am so sorry for this confusion, I did back it out; somehow the impression was the skein boot support is already in 11… my apologies. [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2016 20:43:41 -0000 > On Dec 1, 2016, at 12:34 PM, Toomas Soome wrote: >=20 >=20 >> On 1. dets 2016, at 22:01, Oleksandr Tymoshenko = wrote: >>=20 >>=20 >>> On Dec 1, 2016, at 11:06 AM, Toomas Soome = wrote: >>>=20 >>> Author: tsoome >>> Date: Thu Dec 1 19:06:09 2016 >>> New Revision: 309368 >>> URL: https://svnweb.freebsd.org/changeset/base/309368 >>>=20 >>> Log: >>> MFC r308776 >>>=20 >>> loader: zfs toplevel vdev must have spa set. >>>=20 >>> PR: 214375 >>> Reported by: lstewart >>> Reviewed by: allanjude, imp >>> Approved by: allanjude (mentor), imp (mentor) >>> Differential Revision: https://reviews.freebsd.org/D8487 >>=20 >> Hi Tom, >>=20 >> Looks like this commit breaks the build: >>=20 >> In file included from = /src/FreeBSD/11/sys/boot/efi/loader/../../zfs/zfs.c:49: >> /src/FreeBSD/11/sys/boot/efi/loader/../../zfs/zfsimpl.c:1021:13: = error: no membe >> r named 'spa' in 'struct vdev' >> top_vdev->spa =3D spa; >> ~~~~~~~~ ^ >>=20 >>=20 >>=20 >=20 > Yes, I am so sorry for this confusion, I did back it out; somehow the = impression was the skein boot support is already in 11=E2=80=A6 my = apologies. No problem. Thanks for fixing.=20=