From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Jan 2 15:34:14 2015 Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG> Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B909F3A6 for <freebsd-ports-bugs@FreeBSD.org>; Fri, 2 Jan 2015 15:34:14 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A021B66259 for <freebsd-ports-bugs@FreeBSD.org>; Fri, 2 Jan 2015 15:34:14 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t02FYEgc035915 for <freebsd-ports-bugs@FreeBSD.org>; Fri, 2 Jan 2015 15:34:14 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 196435] Prevent @sample keyword from removing user symlinks Date: Fri, 02 Jan 2015 15:34:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jbeich@vfemail.net X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: <bug-196435-13-8EDQxR1uQd@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-196435-13@https.bugs.freebsd.org/bugzilla/> References: <bug-196435-13@https.bugs.freebsd.org/bugzilla/> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/> List-Post: <mailto:freebsd-ports-bugs@freebsd.org> List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe> X-List-Received-Date: Fri, 02 Jan 2015 15:34:14 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196435 Jan Beich <jbeich@vfemail.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151209|0 |1 is obsolete| | --- Comment #2 from Jan Beich <jbeich@vfemail.net> --- Created attachment 151216 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151216&action=edit v2 (In reply to Mathieu Arnold from comment #1) > Also, for cmp drop the -h, we want symlinks to be followed, otherwise, it'll > compare the content of the file with the path of the sample file, which, in > most cases, won't be the same ;-) Indeed, I've traded one issue for another: - symlink target_file vs. regular sample_file (no filetype check) - symlink target_file vs. symlink sample_file (no symlink path check) - regular target_file vs. regular sample_file - regular target_file vs. symlink sample_file after - symlink target_file vs. regular sample_file (path vs. content) - symlink target_file vs. symlink sample_file - regular target_file vs. regular sample_file - regular target_file vs. symlink sample_file (path vs. content) Let's try to assume target_file cannot be a symlink if unmodified by user or bug 196432 remains closed. -- You are receiving this mail because: You are the assignee for the bug.