From owner-svn-src-all@freebsd.org Sun Jan 3 02:47:57 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A0716A5F13E for ; Sun, 3 Jan 2016 02:47:57 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: from mail-wm0-x22a.google.com (mail-wm0-x22a.google.com [IPv6:2a00:1450:400c:c09::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2ECC218D8 for ; Sun, 3 Jan 2016 02:47:56 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: by mail-wm0-x22a.google.com with SMTP id l65so130343964wmf.1 for ; Sat, 02 Jan 2016 18:47:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sippysoft-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=cOnX6bIqJ36lNThzoX6g/ewsV094UlgFIahdjLmUYYc=; b=Bk1tMTAOhDqTf8JYgdjT9i6qHGlTxyIGDBAhpyxQvp4A8uAazegJaMA40wUO2Bc+C2 QTSAnuF7sGE/ZiR1K9rpFST/TDk7bXjje8KzSH2NWeIOBTc3+8VWXruREmt7o626SFZd PsdTE1D2rD/A7rihFZc0dYRVl/kaB3VlwtWsKFTevQx/eNzgTsttZiygdo5ofhHF87NJ JFpSScNzdZl6G6gI6EaA5wZOdSY0EkAH1Sl6Vjct0POVv/wzLDDSeS4uP59QSQQIKU8p iLRddFvvjRvMXhg+hoqK7o5OAeptx64dVl55MsuqFNRSZcU1xWF8oIzwuopHFQhZm1gf KTVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=cOnX6bIqJ36lNThzoX6g/ewsV094UlgFIahdjLmUYYc=; b=Lcgedfa1m7EY7PeA2rlDLsdt36lcfvg/KHztgxGEFRcBiPaxVnN+GPwAS7hhqWqcUe LHgQ0jRjqggNVtVZsU5xa9+9UiBp1iHFvUR3ctfsRnxhIhE0DjEmhSWjcjeDigBUlPeH xT/DN098ygae8+Qr/kHsStnxaczUqhY9C7+ksaGSA2n+ardOJ2aQhAl3BJgxxMewuURz Q4vGlfqL/f4udiL7YEa649ZDsFqqfSVPXPIeof+TrNGOn4QRcig+3d3I9ybxwNKvL4U9 Hsx1ZmIY6bGOin57+g531mqGeXAxsTbJbC/IqB5tnbtJH4/o/NgZIZVGWvvQX5JZkLvA 1apg== X-Gm-Message-State: ALoCoQl9T9+GapFjsoHDV+ihUBJmcH34JHv4r2rOg8PMLQ0xTJb2N234GXbJbKpWlFbDArVZuT1DvF3Clp62DMpWwJIG0B6Dwuj+aKYGw7RBVbcqN0NImiI= MIME-Version: 1.0 X-Received: by 10.28.222.5 with SMTP id v5mr45556601wmg.94.1451789274961; Sat, 02 Jan 2016 18:47:54 -0800 (PST) Received: by 10.27.39.195 with HTTP; Sat, 2 Jan 2016 18:47:54 -0800 (PST) Received: by 10.27.39.195 with HTTP; Sat, 2 Jan 2016 18:47:54 -0800 (PST) In-Reply-To: <1451774206.1369.109.camel@freebsd.org> References: <201601022231.u02MVEb5037283@repo.freebsd.org> <1451774206.1369.109.camel@freebsd.org> Date: Sat, 2 Jan 2016 18:47:54 -0800 Message-ID: Subject: Re: svn commit: r293063 - head/sys/arm/arm From: Maxim Sobolev To: Ian Lepore Cc: src-committers@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jan 2016 02:47:57 -0000 Don't save commit message and just exit your editor. That should make it abort. Works with CVS, git and svn all the same. Killing your editor with -9 should do as well, as long it doesn't do periodic autosave of some sort. On Jan 2, 2016 2:37 PM, "Ian Lepore" wrote: > On Sat, 2016-01-02 at 22:31 +0000, Ian Lepore wrote: > > Author: ian > > Date: Sat Jan 2 22:31:14 2016 > > New Revision: 293063 > > URL: https://svnweb.freebsd.org/changeset/base/293063 > > > > Log: > > Work around problems that happen when there is ram at the end of the > > physical address space. > > > > Modified: > > head/sys/arm/arm/physmem.c > > > > Modified: head/sys/arm/arm/physmem.c > > > ============================================================================== > > --- head/sys/arm/arm/physmem.c> > Sat Jan 2 22:04:37 2016> > > (r293062) > > +++ head/sys/arm/arm/physmem.c> > Sat Jan 2 22:31:14 2016> > > (r293063) > > @@ -280,10 +280,24 @@ arm_physmem_hardware_region(vm_paddr_t p > > > > /* > > > > * Filter out the page at PA 0x00000000. The VM can't handle > it, as > > > > * pmap_extract() == 0 means failure. > > +> > * > > +> > * Also filter out the page at the end of the physical address > space -- > > +> > * if addr is non-zero and addr+size is zero that means we > wrapped to > > +> > * the next byte beyond what vm_paddr_t can express. The > calculations > > +> > * in vm_page_startup() are going to have the same problem, so > just work > > +> > * around it by leaving the last page out. > > +> > * > > +> > * XXX This just in: subtract out a whole megabyte, not just 1 > page. > > +> > * Reducing the size by anything less than 1MB results in a NULL > pointer > > +> > * deref in _vm_map_lock_read() very early in startup. Better > to give > > +> > * up a whole megabyte than leave some folks with an unusable > system > > +> > * while we investigate. > > > > */ > > > > if (pa == 0) { > > > > > pa = PAGE_SIZE; > > > > > sz -= PAGE_SIZE; > > +> > } else if (pa + sz == 0) { > > +> > > sz -= 1024 * 1024; > > > > } > > > > > > /* > > > > Bah. This is not what I intended to commit, I was going to reword that > comment block to better match what I found while testing. I was > editing the commit message when I decided to do that, so I hit ^C in > the shell that was waiting for me to finish editing in emacs, and to my > surprise it sent the commit instead of cancelling. What's the right > way to change your mind at this late stage of a commit? > > -- Ian > >