From nobody Mon Feb 2 16:55:17 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f4XmQ0wv6z6QjvV for ; Mon, 02 Feb 2026 16:55:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f4XmP5DRSz3Rtf for ; Mon, 02 Feb 2026 16:55:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770051317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=go7lxuUbzwhf9DAEIiP8emVKdyPmUA5cEPRYTe8CaSQ=; b=LOH+TlO9KjKD5PzxPMCYP9wjT1+AthcRW846NGcMmIt+kcvODhCTxb3ZDF5HAIL9ArHQkB UtxQVHfJzcZcT//kb3yQKQL+T3qhWaE5KFa6Tv2mi1UVBFS0S2n33TdsDdnUqH/6/IXKeo ZvxRNxwDBp7YNwgQ806U8iM9mwrWLHZ66xYZ+3duYp1wtbpquhOV9cBawfNlQNpC+u8hpM cWjiPR0FICWn9lE/ODtEa9qY2Ep01m4nb892X9jRmYydV/4bbKV2C6++/DOJPVG5zXABrW wpgj7gg/hSPcOioRubZwRyIvq3papHd5zS1JRldieuOGfwhDVVfsJBzqPyPRIA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770051317; a=rsa-sha256; cv=none; b=OhJJNiizsBbLAlFiidXDN11t1YVTLaBkfuBte5/y8GoQNPLLUdnLRe812bOvpS+Ze0fUTg VbXAhrG+WAQt5NZF9i3dMqTMJ7X/GEU8cxgFAl9pIRMmu0h77j5mGcgIWvfTo7pJojzPDV i62o2oghnHHXqxQb+nGOQGjxeAHWiL/rTTFBg64eAB+fzSu23Oq1KNOZhbzdkP+V6Is981 GK5i6TsvEQNIjiDy0ZGkKqxG8sXIwegye7JARBiCKRMRN5xuTTF8LDUGxw+TOQXJxPt5I0 JgaR7O/QF8Cm4dKVAUlGeDjGxFvp+u7JYt+oaT1DP4DotCV1EOLyLcTHSvM66g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770051317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=go7lxuUbzwhf9DAEIiP8emVKdyPmUA5cEPRYTe8CaSQ=; b=V08FD2h41gfT3EwXe2jXz7VtGEjYTL6+xCUHg+ABhrh3a+oxnelJuKHJmOcRjthusujZhF iS3Jrh8v++lqyb+phmPnNxC14IdMiCnaf8ekwuHJn5y6DzH74wvwQvWe1MnA25xskT/+TH nPZah0k4cEOU5R+Px40snDukKdaLcsKqL+gvNyCgOPfgugQCLAMT92p9BV7+R4LvNHmFuT leb2+FsiS839MLPCkczJVUTPUJ9sZnDM3svdgLvEA6L/uX4kTsDZM/t8ybB6FEbBt5JFnb 3PbzUpg67FOFBkwnXlqKWLLFPIFQHkfIHUeBdiiyskZTfmou6aqQp8I6XekY1w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f4XmP4b95zbgs for ; Mon, 02 Feb 2026 16:55:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1bbe1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 02 Feb 2026 16:55:17 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: b370fcc716b9 - main - ip6_mroute: Make MF6CFIND a regular function List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b370fcc716b9cfd4d08e291f0009f02452c84d64 Auto-Submitted: auto-generated Date: Mon, 02 Feb 2026 16:55:17 +0000 Message-Id: <6980d6f5.1bbe1.5f30729c@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=b370fcc716b9cfd4d08e291f0009f02452c84d64 commit b370fcc716b9cfd4d08e291f0009f02452c84d64 Author: Mark Johnston AuthorDate: 2026-02-02 14:57:20 +0000 Commit: Mark Johnston CommitDate: 2026-02-02 16:54:54 +0000 ip6_mroute: Make MF6CFIND a regular function This is more natural and corresponds more closely to the v4 multicast routing code. No functional change intended. Reviewed by: glebius MFC after: 2 weeks Sponsored by: Stormshield Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D54983 --- sys/netinet6/ip6_mroute.c | 45 ++++++++++++++++++++------------------------- 1 file changed, 20 insertions(+), 25 deletions(-) diff --git a/sys/netinet6/ip6_mroute.c b/sys/netinet6/ip6_mroute.c index 6ca17774784b..705aba0bfa94 100644 --- a/sys/netinet6/ip6_mroute.c +++ b/sys/netinet6/ip6_mroute.c @@ -296,26 +296,6 @@ VNET_DEFINE_STATIC(int, pim6); (g).s6_addr32[0] ^ (g).s6_addr32[1] ^ \ (g).s6_addr32[2] ^ (g).s6_addr32[3]) -/* - * Find a route for a given origin IPv6 address and Multicast group address. - */ -#define MF6CFIND(o, g, rt) do { \ - struct mf6c *_rt = mf6ctable[MF6CHASH(o,g)]; \ - rt = NULL; \ - while (_rt) { \ - if (IN6_ARE_ADDR_EQUAL(&_rt->mf6c_origin.sin6_addr, &(o)) && \ - IN6_ARE_ADDR_EQUAL(&_rt->mf6c_mcastgrp.sin6_addr, &(g)) && \ - (_rt->mf6c_stall == NULL)) { \ - rt = _rt; \ - break; \ - } \ - _rt = _rt->mf6c_next; \ - } \ - if (rt == NULL) { \ - MRT6STAT_INC(mrt6s_mfc_misses); \ - } \ -} while (/*CONSTCOND*/ 0) - /* * Macros to compute elapsed time efficiently * Borrowed from Van Jacobson's scheduling code @@ -366,6 +346,22 @@ static int X_ip6_mrouter_set(struct socket *, struct sockopt *); static int X_ip6_mrouter_get(struct socket *, struct sockopt *); static int X_mrt6_ioctl(u_long, caddr_t); +static struct mf6c * +mf6c_find(const struct in6_addr *origin, const struct in6_addr *group) +{ + MFC6_LOCK_ASSERT(); + + for (struct mf6c *rt = mf6ctable[MF6CHASH(*origin, *group)]; rt != NULL; + rt = rt->mf6c_next) { + if (IN6_ARE_ADDR_EQUAL(&rt->mf6c_origin.sin6_addr, origin) && + IN6_ARE_ADDR_EQUAL(&rt->mf6c_mcastgrp.sin6_addr, group) && + rt->mf6c_stall == NULL) + return (rt); + } + MRT6STAT_INC(mrt6s_mfc_misses); + return (NULL); +} + /* * Handle MRT setsockopt commands to modify the multicast routing tables. */ @@ -494,7 +490,7 @@ get_sg_cnt(struct sioc_sg_req6 *req) MFC6_LOCK(); - MF6CFIND(req->src.sin6_addr, req->grp.sin6_addr, rt); + rt = mf6c_find(&req->src.sin6_addr, &req->grp.sin6_addr); if (rt == NULL) { ret = ESRCH; } else { @@ -817,9 +813,8 @@ add_m6fc(struct mf6cctl *mfccp) MFC6_LOCK(); - MF6CFIND(mfccp->mf6cc_origin.sin6_addr, - mfccp->mf6cc_mcastgrp.sin6_addr, rt); - + rt = mf6c_find(&mfccp->mf6cc_origin.sin6_addr, + &mfccp->mf6cc_mcastgrp.sin6_addr); /* If an entry already exists, just update the fields */ if (rt) { MRT6_DLOG(DEBUG_MFC, "no upcall o %s g %s p %x", @@ -1114,7 +1109,7 @@ X_ip6_mforward(struct ip6_hdr *ip6, struct ifnet *ifp, struct mbuf *m) /* * Determine forwarding mifs from the forwarding cache table */ - MF6CFIND(ip6->ip6_src, ip6->ip6_dst, rt); + rt = mf6c_find(&ip6->ip6_src, &ip6->ip6_dst); MRT6STAT_INC(mrt6s_mfc_lookups); /* Entry exists, so forward if necessary */