From owner-svn-src-all@FreeBSD.ORG Thu Dec 22 20:12:35 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 29D85106566B; Thu, 22 Dec 2011 20:12:35 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id 659948FC08; Thu, 22 Dec 2011 20:12:34 +0000 (UTC) Received: by eekc50 with SMTP id c50so10406156eek.13 for ; Thu, 22 Dec 2011 12:12:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=hACawBSk3yU+GUs6Dew5vq2OOVzooNcSFp6aYiHXtFc=; b=FCPtrl5m8binZxbLX44Sz6/9YOZ41eS9TH83uGWNiaM1M1iqt2M025eGaAwFiKVUZ0 FzNF6MUKOiZsO0q+tdL/ZaHW7TOFimqaLG+N4vEXsItHlJfCMd3qzjLlYxC5Qo+R6+mf maiwMS2QeQK94gdl+RnpoFbyZVUsTvPUp9wVY= Received: by 10.213.4.138 with SMTP id 10mr5515063ebr.19.1324582910969; Thu, 22 Dec 2011 11:41:50 -0800 (PST) Received: from mavbook.mavhome.dp.ua (pc.mavhome.dp.ua. [212.86.226.226]) by mx.google.com with ESMTPS id 76sm38112234eeh.0.2011.12.22.11.41.48 (version=SSLv3 cipher=OTHER); Thu, 22 Dec 2011 11:41:50 -0800 (PST) Sender: Alexander Motin Message-ID: <4EF387F4.9050008@FreeBSD.org> Date: Thu, 22 Dec 2011 21:41:40 +0200 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:8.0) Gecko/20111112 Thunderbird/8.0 MIME-Version: 1.0 To: Andriy Gapon References: <201112221640.pBMGeZod025237@svn.freebsd.org> <4EF375E5.2010809@FreeBSD.org> In-Reply-To: <4EF375E5.2010809@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r228808 - head/sys/cam/scsi X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2011 20:12:35 -0000 On 22.12.2011 20:24, Andriy Gapon wrote: > on 22/12/2011 18:40 Alexander Motin said the following: >> Author: mav >> Date: Thu Dec 22 16:40:35 2011 >> New Revision: 228808 >> URL: http://svn.freebsd.org/changeset/base/228808 >> >> Log: >> Make cd driver to handle Audio CDs, reporting their 2352 bytes sectors to >> GEOM and using READ CD command for reading data, same as acd driver does. >> Audio CDs identified by checking respective bit of the control field of >> the first track in TOC. >> >> This fixes bunch of error messages during boot (GEOM taste) with Audio CD >> inserted and allows to grab Audio CD image using just dd. > > Thank you! > What about CDs with mixed audio and data tracks? > I don't ask for any support, just curious if our users could run into any > troubles with those. If data track is the first (I don't know whether it is mandatory, but wiki tells it is usual), the whole disk will be handled as data by the driver and work as before (only data part will be readable). If it can be not the first, then I am not sure how acd driver works with it, but we can just make check a bit more strict, switching to data if found it anywhere on disk. Any way I don't think we will see many Mixed Mode CDs in the future, while Audio CDs are still on market. If you worry about audio extraction of Mixed Mode CDs, then quick look on mplayer and it's underlying cdparanoia and libcdio shows that they are extracting audio data talking directly to the drive using SCSI commands, so cd driver is irrelevant for them. So this change is mostly about staying consistent when possible with a small blood. -- Alexander Motin