From owner-svn-src-projects@FreeBSD.ORG  Mon Nov 24 07:48:47 2014
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id CFBA5AFB;
 Mon, 24 Nov 2014 07:48:47 +0000 (UTC)
Received: from mail.fer.hr (mail.fer.hr [161.53.72.233])
 (using TLSv1 with cipher AES128-SHA (128/128 bits))
 (Client CN "mail.fer.hr", Issuer "TERENA SSL CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 63575A4B;
 Mon, 24 Nov 2014 07:48:46 +0000 (UTC)
Received: from x23 (161.53.63.210) by MAIL.fer.hr (161.53.72.233) with
 Microsoft SMTP Server (TLS) id 14.2.342.3; Mon, 24 Nov 2014 08:48:37 +0100
Date: Mon, 24 Nov 2014 08:48:38 +0100
From: Marko Zec <zec@fer.hr>
To: Gleb Smirnoff <glebius@freebsd.org>
Subject: Re: svn commit: r274921 - projects/routing/sys/net
Message-ID: <20141124084838.2af0f2cd@x23>
In-Reply-To: <20141124065122.GE47144@FreeBSD.org>
References: <201411231747.sANHlC9Y088840@svn.freebsd.org>
 <20141124065122.GE47144@FreeBSD.org>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.22; amd64-portbld-freebsd10.0)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [161.53.63.210]
Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org,
 "Alexander V. Chernikov" <melifaro@freebsd.org>
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Nov 2014 07:48:47 -0000

On Mon, 24 Nov 2014 09:51:22 +0300
Gleb Smirnoff <glebius@freebsd.org> wrote:

> On Sun, Nov 23, 2014 at 05:47:12PM +0000, Alexander V. Chernikov
> wrote:
> A> Author: melifaro
> A> Date: Sun Nov 23 17:47:12 2014
> A> New Revision: 274921
> A> URL: https://svnweb.freebsd.org/changeset/base/274921
> A> 
> A> Log:
> A>   Finish r274335#2: put RT_LOCK_DESTROY() back.
> A> 
> A> Modified:
> A>   projects/routing/sys/net/route.c
> A> 
> A> Modified: projects/routing/sys/net/route.c
> A> ==============================================================================
> A> --- projects/routing/sys/net/route.c	Sun Nov 23 17:45:49
> A> 2014	(r274920) +++ projects/routing/sys/net/route.c
> A> Sun Nov 23 17:47:12 2014	(r274921) @@ -1505,6 +1505,7 @@
> A> rtrequest1_fib(int req, struct rt_addrin if (rn == NULL) {
> A>  			ifa_free(rt->rt_ifa);
> A>  			Free(rt_key(rt));
> A> +			RT_LOCK_DESTROY(rt);
> A>  			uma_zfree(V_rtzone, rt);
> A>  #ifdef FLOWTABLE
> A>  			if (rt0 != NULL)
> 
> Don't know about your branch, but in head RT_LOCK_DESTROY is done
> in V_rtzone finit method. So you are going to hit destroying of
> already destroyed mutex.
> 
> btw, I see no good reason for virtualizing the zone. (Yep, I did
> that.) :)

Having virtualized zones comes quite handy while hacking up new stuff to
track VIMAGE memory leaks, but once the bugs get cleaned up and if the
V_ stuff gets commited to head, it apparently becomes difficult to
persuade people to de-virtualize...

Marko