From owner-svn-src-all@FreeBSD.ORG Tue Oct 23 17:59:44 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 961CA388; Tue, 23 Oct 2012 17:59:44 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id E4C618FC0C; Tue, 23 Oct 2012 17:59:43 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q9NHxlO6070161; Tue, 23 Oct 2012 20:59:47 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q9NHxa0k025199; Tue, 23 Oct 2012 20:59:36 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q9NHxZlw025198; Tue, 23 Oct 2012 20:59:35 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 23 Oct 2012 20:59:35 +0300 From: Konstantin Belousov To: Maxim Sobolev Subject: Re: svn commit: r241625 - head/usr.sbin/cron/cron Message-ID: <20121023175935.GY35915@deviant.kiev.zoral.com.ua> References: <201210170044.q9H0iZHo055977@svn.freebsd.org> <20121017174814.GN35915@deviant.kiev.zoral.com.ua> <507F0FF8.3090602@FreeBSD.org> <20121017201811.GO35915@deviant.kiev.zoral.com.ua> <50856FE9.1020807@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5nUKqBW0XvnsonJi" Content-Disposition: inline In-Reply-To: <50856FE9.1020807@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2012 17:59:44 -0000 --5nUKqBW0XvnsonJi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 22, 2012 at 09:10:17AM -0700, Maxim Sobolev wrote: > Guys, >=20 > The latest version of the patch against current HEAD is available here: >=20 > http://sobomax.sippysoft.com/cron.diff >=20 > Any comments/suggestions are appreciated. This version should default to= =20 > previous behaviour of waking up every 60 seconds unless there is=20 > @every_second entry in the cron. >=20 > Konstantin, can you please put it for testing to your boxes? Please make= =20 > sure to do `make clean' after applying it, as libcron is not listed as a= =20 > dependency for cron, so it's possible that some changes may not be=20 > picked up. I patched the HEAD with the provided diff, and did make clean all in usr.sbin/cron. The resulting binary correctly handled both /etc/crontab and personal crontabs with the each-minute jobs. I did not read the changed logic. Still, I suggest you to wrap the too-long line in the patch. Also, it seems that the changes would benefit from (extensive) commenting in the code. --5nUKqBW0XvnsonJi Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAlCG2wcACgkQC3+MBN1Mb4i0lACg4XaUp9zqsXjIlrTiiiBrBrQO HjYAnRMK1IZ6FmobeGnHNm878IZ0rsqZ =Pcdk -----END PGP SIGNATURE----- --5nUKqBW0XvnsonJi--