From nobody Tue Jan 27 18:44:24 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f0vT51W4Gz6QG6h for ; Tue, 27 Jan 2026 18:44:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f0vT423L7z3rPR for ; Tue, 27 Jan 2026 18:44:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769539464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eVHs3d1iRzTQXhFUQmQhz706tee9/czJjg0RuSGfDDw=; b=sfBzGSRa5ry/wLeYCj9tFugLy8RrfQtKdvZ0ottmgRyPcmHddoIVzvKvyZhJqvfCe0j7Ib tRrUtTJYOdi/QfsnhS5ULjr5URnK+sfOkbJQjNF5mgadGLa5NbAZ1V7xcf7wMyHicz2mJO eSA8Sez0NEVeLMa51+d0U5cp0bU4zrb97ZkPHyaxwv5/u1m9Nbs+zKh2iCokI8JU/NRXmg kBQtTiyPQEogXhpdgtlCKoqGmP2NF21dtdZcg/6OYjsye7w4P/tWg3gz30AZgo0ndwpJWu O/KqS2WBo1Sh3hsD5T9t9ElrI8lhzfGA6IUn/3DnorvXzHVPniWUS8DA3q/PJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769539464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eVHs3d1iRzTQXhFUQmQhz706tee9/czJjg0RuSGfDDw=; b=RqtSm/FERp7WBhRdbC8lyR8Yv+Ihs9RtzytxNZZpQQUxASkskojYeW48ZYUaioMgeDZ0v5 I6C2mUE1uRZUMduxlY0bDAlWjqR5oyi5qG2eooM7B44iz9rc4pLfk8CyICD4IpQyaI1r6K VeMNvRBLb/7jhvufJgtCaw+LWkRMJ5rIejaIf8+yomAzUfiQZE8ECx7cXQeOK7rMvHnfZ1 6X6qqCVrlMwubW5gcyZmApO76z3udAKBpBqRddPHR9CA7Abv6EF8zM2Yefbppf7hGNl7Ct kvb80LhEG8BZEGXOVtHweDKW392sTcfxhHgFHObX18CTIR2aQL4ip0KzYfRYwA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769539464; a=rsa-sha256; cv=none; b=Yq2MM3msiTJGRaecufcfUrn3LocM5R+BAKWy9qkFALEldnjL/JYSO+iGNEb8vVmhdCghoq A4VnUlBIZsvXlRgWXni49Y67bLxO5iL1LNNUh9sHce2RFE5nMs43iCKKT4ULTzbxkpk//T yNnZ4VQPKamBWNZrGZOdp4KRPKRoL+M4JmbR7uVphTQNluPzDi+78GLIBDNUheYmO5Am80 PCggnAyvPr9aocqgiOsPmyFA/7pAJYEqy9QZE/fMDyd3c6tjtMw90B71DJ2Gh8Xw99r2/0 xN6Nv84Ja+4SNtrQDzU5HedBes7DsUm53i9QYSekkv68dq0gUBbNuO3diHhTAg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f0vT40slcz3tX for ; Tue, 27 Jan 2026 18:44:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id f7e0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 27 Jan 2026 18:44:24 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: bce125030930 - stable/14 - ctld: Disable -Wshadow for GCC List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: bce1250309302f66165a536c2834c7fc515ebc74 Auto-Submitted: auto-generated Date: Tue, 27 Jan 2026 18:44:24 +0000 Message-Id: <69790788.f7e0.57df8263@gitrepo.freebsd.org> The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=bce1250309302f66165a536c2834c7fc515ebc74 commit bce1250309302f66165a536c2834c7fc515ebc74 Author: John Baldwin AuthorDate: 2025-04-11 13:34:36 +0000 Commit: John Baldwin CommitDate: 2026-01-27 18:15:57 +0000 ctld: Disable -Wshadow for GCC GCC raises shadow warnings in C++ when a global function shadows a structure type name (since it shadows the constructors for that type). System headers are full of such cases (and some such as struct sigaction vs sigaction() are mandated by POSIX), so just disable the warning. For example: In file included from usr.sbin/ctld/ctld.cc:33: sys/sys/event.h:366:20: error: 'int kqueue()' hides constructor for 'struct kqueue' [-Werror=shadow] 366 | int kqueue(void); | ^ sys/sys/event.h:371:43: error: 'int kevent(int, const kevent*, int, kevent*, int, const timespec*)' hides constructor for 'struct kevent' [-Werror=shadow] 371 | const struct timespec *timeout); | ^ In file included from usr.sbin/ctld/ctld.cc:37: sys/sys/stat.h:396:63: error: 'int stat(const char*, stat*)' hides constructor for 'struct stat' [-Werror=shadow] 396 | int stat(const char * __restrict, struct stat * __restrict); | ^ Reported by: bz (cherry picked from commit 75a24e7f9afb128138c3b3462b80731cab0f5bdd) --- usr.sbin/ctld/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/usr.sbin/ctld/Makefile b/usr.sbin/ctld/Makefile index 737d09446db8..ed6d8d5f9b5d 100644 --- a/usr.sbin/ctld/Makefile +++ b/usr.sbin/ctld/Makefile @@ -15,6 +15,7 @@ CFLAGS+= -I${SRCTOP}/sys/dev/iscsi CFLAGS+= -I${SRCTOP}/lib/libiscsiutil #CFLAGS+= -DICL_KERNEL_PROXY NO_WCAST_ALIGN= +CXXWARNFLAGS.gcc= -Wno-shadow MAN= ctld.8 ctl.conf.5 LIBADD= bsdxml iscsiutil md sbuf util ucl m nv