From owner-freebsd-testing@freebsd.org Sun Apr 12 18:46:30 2020 Return-Path: Delivered-To: freebsd-testing@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3A0E72C58DB for ; Sun, 12 Apr 2020 18:46:30 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 490gh60lGrz4TvK; Sun, 12 Apr 2020 18:46:29 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-yb1-f174.google.com with SMTP id t10so4161494ybk.8; Sun, 12 Apr 2020 11:46:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f5Jsp/mvEhVFIqDI2A1V+g3bkZpfBqwDytxluEVG74M=; b=dSGvpJG7uL/d8J33JCWjpIunRmOmScgZ+y1O2mpo9kJ3QTbkprbyxr0S2OuygUJGRO qJZxeYjhp7sFNXt0EBaPUf0DoEhAemG9IGFCIOBxyjiHngNH3/6LxCXV9GY8ii5KlIoC bGMJNyY8l6x+74nejwmuEu3pBLNsZQv65v5y7hrR8MnTCtpVquOrvnxtpooFj7zbD5MZ X1qkzsJBJFQ0a5Kk0S4tR9QpJ4PP+yj6HWUedincbsXdcIpBFT0MdgWlclyNAbgXWrc6 1ozdhE/1TTI33Iztmbj2LJEAoROV8+ODjlcfAKGFUFJmpG6bhWR0wqJikabr1HYkDGpn zm6w== X-Gm-Message-State: AGi0PuZhPeElvdsLXcq/6K3+HJ+0vIzyJXJYBdBDrp6ZgCtGY9FQkjAh RvSbwnbi9YqvFwCy1aABqbovPJxuep+7q3qrZN/NwZNK X-Google-Smtp-Source: APiQypJMgDo2lyUL0GB1DbDu0+d2nBPDvX2oQhjvWj0gBR5nSfV8eoy84IdMluKM7Gb8FrKt0zdgNXksUCs/CLnfjkA= X-Received: by 2002:a25:80c4:: with SMTP id c4mr22974962ybm.110.1586717188720; Sun, 12 Apr 2020 11:46:28 -0700 (PDT) MIME-Version: 1.0 References: <6963991586714482@vla4-4046ec513d04.qloud-c.yandex.net> In-Reply-To: <6963991586714482@vla4-4046ec513d04.qloud-c.yandex.net> From: Li-Wen Hsu Date: Mon, 13 Apr 2020 02:46:17 +0800 Message-ID: Subject: Re: ipdivert tests and net.inet.ip.fw.default_to_accept To: "Alexander V. Chernikov" Cc: "freebsd-testing@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 490gh60lGrz4TvK X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Apr 2020 18:46:30 -0000 On Mon, Apr 13, 2020 at 2:09 AM Alexander V. Chernikov wrote: > 12.04.2020, 18:45, "Li-Wen Hsu" : > > I'm checking test failures and panics, and found that the two ipdivert > > tests we added previously have never been tested correctly. I've > Yep, I've been running tests manually but haven't managed to raise a pull request to auto-load ipdivert prior to the tests yet. It think it's okay for now. I've merged this PR https://github.com/freebsd/freebsd-ci/pull/34 and now we have loaded all the modules needed. I somehow feel it's crazy and default_to_accept might have side effect like what we already saw. Anyway. I'm leaving them there for now and move to checking other failures and panics first. Also thanks for checking relative codes. That's the reason we need tests!