From owner-svn-src-all@freebsd.org Wed May 22 16:49:23 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7DF0715B1145; Wed, 22 May 2019 16:49:23 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1A6C88E912; Wed, 22 May 2019 16:49:23 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd2f.google.com with SMTP id z4so2448935iol.0; Wed, 22 May 2019 09:49:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Y5d/zsUdRPtDhcymNkvXKaVGvKryaTtYeA7AUlqbrGA=; b=XECWld8v6zMCO7YgGl53PK0E3A0xwCYH4hpYzhBpEd8FPOJ1AFncdMmJmoxflOg/d4 /7TqUt+JFs0Td+z6vuU7WBpl1PaGHPjc7hqi+459V/GfY32IjMlbDjNe3oaJr51p3+ST eqh9X7LxtHw2RXi3AT9bgfbZILEj5qL/2qqdIDGbC+q3pMeYadG91rhArrzViEUM5+uk aM1Oy/i6MZQpknMb7l+TCkOwxq8vqCW9zYoW3R0rMXE/Su0dMuCDg67R6LGe3qpgSSbD GvcgS658FHfGyyltoZr8ySILJKSREU8nxfE77vWC5mhYSABeWuqRne9guR+yQ9Noq4Ie 8ZFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=Y5d/zsUdRPtDhcymNkvXKaVGvKryaTtYeA7AUlqbrGA=; b=al/GwAw0wiR76UoYqJyZ8RC3O3Vko4vcgv+XgBscp7b5f44UPd0MH5sNT1S7t01Ub3 8COt04HQvOqp5aVSS8kYSlhSYAea/5fUqgDbZZVz1ZEYjMYX7Zcc2sxldQlyKEf5KQMg wyOtRzWVQ6ufwb4Vd8FBCoaOZmSNdFxapKtbghiysbbm1pgojfUTS57J5tA7tJ7I24sR a2PTcNnDIM+pA8Ma9YiqdnM7FZR0E1HqMZfILFx3zgDaTvqNbi1fYHbhmzeIM9b3W+PM 0nSZZ5UOy5g4Yf2LvZUim/fAPi209JRGVrpVhxu8+Y6wNKTOKTT8FhtT6VCMp3MHmZgl S07g== X-Gm-Message-State: APjAAAWE36HeK5ByJZUG4nwfnYVvxvjn5ZkL0ppkL3SGdINnWiUOSXYC PPJSUfQt3+x6quHiLkH4Pp1c1vo3 X-Google-Smtp-Source: APXvYqwvtguJg8t6N4P3PqH2iwXwDNMjNi+vB7o9MNN0c+oVPIkS8okBlv9FWBiQUb1Ve6XjQu6WrA== X-Received: by 2002:a5e:8513:: with SMTP id i19mr30472602ioj.119.1558543761884; Wed, 22 May 2019 09:49:21 -0700 (PDT) Received: from spy (cs-auth-dc-129-97-60-193.dynamic.uwaterloo.ca. [129.97.60.193]) by smtp.gmail.com with ESMTPSA id y99sm3022842ita.23.2019.05.22.09.49.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 May 2019 09:49:21 -0700 (PDT) Sender: Mark Johnston Date: Wed, 22 May 2019 12:49:19 -0400 From: Mark Johnston To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r348090 - in head/libexec/bootpd: . bootpgw Message-ID: <20190522164919.GC5125@spy> References: <20190522151116.GB5125@spy> <201905221548.x4MFmAIF085473@gndrsh.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201905221548.x4MFmAIF085473@gndrsh.dnsmgr.net> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 1A6C88E912 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.96)[-0.959,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 May 2019 16:49:23 -0000 On Wed, May 22, 2019 at 08:48:10AM -0700, Rodney W. Grimes wrote: > > On Tue, May 21, 2019 at 09:25:23PM -0700, Rodney W. Grimes wrote: > > To be honest I have no desire to spend more time on bootpd than I > > already have. You are welcome to improve the usage formatting if > > you like. > > omg, really? Old "folke lore" You touched, you own it. I own plenty of things already. > If I didnt have to go through bde and/or phk I would of just gone > and commited the clean up. Ok, that's something for you to figure out. > I have handed you the diff. > > Perhaps a phab review before would of made this less painfull. > And perhaps a phab review once an issue had been raised would > of been really less painful. There was a phab review for the original change, and I fixed an issue that was introduced by that change. I think that's sufficient.