From nobody Fri Aug 30 01:05:02 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ww0LQ4lphz5MmNW; Fri, 30 Aug 2024 01:05:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ww0LQ44hQz4n1X; Fri, 30 Aug 2024 01:05:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724979902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aE8LjichO5nhXSVbdEZ6juXjyW/rP/2w7UYZw6tiPsw=; b=sRtIYY/6WihPWt7PbUAbcO0kJIyd4x8V738oJUXzbWAuPySMms0keeHM1TS67iaxBxJkK7 mS2ZHuh1s//hHNRc9yG8Wkltl9bZGnZMnHh8l3w5BlRoI6dBoWsVGPxrbyZPbVknWsFQGV /u8SHB1eqJeFkoiTnlhUFKk9OUIMHH+gWdjpeHgfIWc2/eVr7+UQkvV5O4hB4Yhl5O9T7q YdyiXBvIGZ4Nof4fUTHKOLSMbShBUoatQoVkkXxD2Yf3UEvipzoY9DgjVJYcHtPjj1oYSE vG8qxHGUGzvKuYRyPUDFUJEGqmuBW76s5jIolifRkjyCSjYV//Hs4wM19OGcJw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724979902; a=rsa-sha256; cv=none; b=H5NRDhlVJOgJDdfaCk+R6IKNLQ1eKJsUGg1lDMH9rs3skFL4Mkf1dyLS0Ir5PSu4eRz9gl Ro9ojqIPj0wAgJER5ki+skKss+FtjCWdvcoR6xqQ+3wYf8b1s3oRw+INl45dtn37Jm+dSV PPBO2netcSajv8JpBFdcf2eCLZWGpDYLHI2qDNS9HOjYGgKeRUyzgGJlttfrBgxv3HfdGc OKsr6LRvEO/cPnb2doEEuBK1sJu5RPLkbagni/euEsuqcRFbygH3ACfd07By9r+VmHXvU8 G3p0j+V+03Oo36z19EtfcCyxikoDWor22oG1vnoy295vVU2rj5mLrOYK0x17XQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724979902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aE8LjichO5nhXSVbdEZ6juXjyW/rP/2w7UYZw6tiPsw=; b=HUNtNhBD5HwsrdZX9yBV1t66AQYK9PYWxeJ3QL1fXR37LFvi7ysU28PMi/asbrHRE36IKZ 7uFtt4UA3nPfhITYO07jMJiwR2h8OCt++GhOuaF1QoIUMVVoRDiKLuGyGNoEC761e4bku4 WhLjY6+NWS23KZROc1znvSAqzz83T4qkXbnFmUzo7/AasNgUk8nSsWXV9cQpMrwpo13WRJ VQ1s7MZz5rOW98ePOLT7pqUal6z4c0EbvUtBqK8E390qB4J/lBI8l1RdrLZUdTbqSKlxXk 0yrQGYu+WEEPHguVUNEqRJoOevue75mfvI9I9Xn3LOlNIuAfamgEvVDn0jAdkw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ww0LQ3Yyjzgxw; Fri, 30 Aug 2024 01:05:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47U152qe095211; Fri, 30 Aug 2024 01:05:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47U152s5095208; Fri, 30 Aug 2024 01:05:02 GMT (envelope-from git) Date: Fri, 30 Aug 2024 01:05:02 GMT Message-Id: <202408300105.47U152s5095208@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Navdeep Parhar Subject: git: 3b4dcc0feb41 - main - cxgbe/iw_cxgbe: c4iw_connect should return a negative errno. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3b4dcc0feb41120017381681d612d3cc21beb1d7 Auto-Submitted: auto-generated The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=3b4dcc0feb41120017381681d612d3cc21beb1d7 commit 3b4dcc0feb41120017381681d612d3cc21beb1d7 Author: Navdeep Parhar AuthorDate: 2024-08-30 00:43:43 +0000 Commit: Navdeep Parhar CommitDate: 2024-08-30 00:58:36 +0000 cxgbe/iw_cxgbe: c4iw_connect should return a negative errno. Avoid a pointless assignment while here. MFC after: 1 week Sponsored by: Chelsio Communications --- sys/dev/cxgbe/iw_cxgbe/cm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/dev/cxgbe/iw_cxgbe/cm.c b/sys/dev/cxgbe/iw_cxgbe/cm.c index c3d334aa0f62..d8def446d6f0 100644 --- a/sys/dev/cxgbe/iw_cxgbe/cm.c +++ b/sys/dev/cxgbe/iw_cxgbe/cm.c @@ -2655,8 +2655,7 @@ int c4iw_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) CTR2(KTR_IW_CXGBE, "%s:cc7 %p", __func__, ep); printk(KERN_ERR MOD "%s - cannot find route.\n", __func__); - err = EHOSTUNREACH; - return err; + return -EHOSTUNREACH; } if (!(if_getcapenable(nh_ifp) & IFCAP_TOE) ||