From owner-freebsd-hackers@FreeBSD.ORG  Tue Mar  4 16:00:55 2008
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CEE431065716;
	Tue,  4 Mar 2008 16:00:55 +0000 (UTC)
	(envelope-from keramida@ceid.upatras.gr)
Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36])
	by mx1.freebsd.org (Postfix) with ESMTP id 4395B8FC27;
	Tue,  4 Mar 2008 16:00:54 +0000 (UTC)
	(envelope-from keramida@ceid.upatras.gr)
Received: from kobe.laptop (vader.bytemobile-rio.ondsl.gr [83.235.57.37])
	(authenticated bits=128)
	by igloo.linux.gr (8.14.1/8.14.1/Debian-9) with ESMTP id m24G0CMk001726
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Tue, 4 Mar 2008 18:00:33 +0200
Received: from kobe.laptop (kobe.laptop [127.0.0.1])
	by kobe.laptop (8.14.2/8.14.2) with ESMTP id m24G07DX096966;
	Tue, 4 Mar 2008 18:00:07 +0200 (EET)
	(envelope-from keramida@ceid.upatras.gr)
Received: (from keramida@localhost)
	by kobe.laptop (8.14.2/8.14.2/Submit) id m24G07Ht096965;
	Tue, 4 Mar 2008 18:00:07 +0200 (EET)
	(envelope-from keramida@ceid.upatras.gr)
Date: Tue, 4 Mar 2008 18:00:07 +0200
From: Giorgos Keramidas <keramida@ceid.upatras.gr>
To: "M. Warner Losh" <imp@bsdimp.com>
Message-ID: <20080304160006.GB95950@kobe.laptop>
References: <20080304.083350.1661915009.imp@bsdimp.com>
	<20080304153651.I41184@fledge.watson.org>
	<20080304154542.GC61036@kobe.laptop>
	<20080304.085245.2040341894.imp@bsdimp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080304.085245.2040341894.imp@bsdimp.com>
X-Hellug-MailScanner: Found to be clean
X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached,
	score=-3.975, required 5, autolearn=not spam, ALL_TRUSTED -1.80,
	AWL 0.42, BAYES_00 -2.60)
X-Hellug-MailScanner-From: keramida@ceid.upatras.gr
X-Spam-Status: No
Cc: hackers@FreeBSD.org, rwatson@FreeBSD.org
Subject: Re: Comments on pmake diffs for building on Linux
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Mar 2008 16:00:55 -0000

On 2008-03-04 08:52, "M. Warner Losh" <imp@bsdimp.com> wrote:
> In message: <20080304154542.GC61036@kobe.laptop>
>             Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
> : Nice!  Thank you Robert.  Can I copy parts of this and add them to the
> : autoconf glue I'm adding now?
> :
> : To test just cpp(1) stuff, autoconf supports AC_PREPROC_IFELSE() too,
> : which I used when I tried writing a check for __FBSDID():
> :
> :   AC_PREPROC_IFELSE(
> :     [AC_LANG_PROGRAM([[#include <sys/cdefs.h>
> :   #ifndef __FBSDID
> :   #error No __FBSDID definition.
> :   #endif]])],
> :     [AC_DEFINE([HAVE_FBSDID_MACRO], [1],
> :        [Define to 1 if you have the __FBSDID macro.])])
> :
> : I can probably improve a bit the queue.h check using what you wrote
> : above and AC_PREPROC_IFELSE().
>
> The alternative to uglifying the make sources with #ifdefs would be to
> just always use the compat includes when building...  No autoconf
> needed, and minimal changes to the base make, if any.

True.  I'll try to keep #ifdef changes down to the absolutely _minimum_
amount of changes.  It will make repeated merged from usr.bin/make much
easier, for example :)