Date: Thu, 20 Sep 2012 20:37:19 +1200 From: Andrew Thompson <thompsa@FreeBSD.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: net@freebsd.org Subject: Re: [CFT] if_transmit method for lagg(4) Message-ID: <CAFAOGNTE_HO4TScR0ztUihbs%2BfXeP6_jENvWTcnudK65J=1%2B-Q@mail.gmail.com> In-Reply-To: <20120920074730.GS85604@FreeBSD.org> References: <20120920074730.GS85604@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--f46d042dfdd90c608304ca1e087d Content-Type: text/plain; charset=ISO-8859-1 On 20 September 2012 19:47, Gleb Smirnoff <glebius@freebsd.org> wrote: > Hi, > > Yet another patch to test. Was suprising to me that lagg(4), which > aims at high-performance, still utilizes if_start. > > Attached is patch that converts lagg(4) to use if_transmit. I'd > appreciate if someone who do use lagg(4) tests the patch. If anyone > benchmarks lagg(4) with and w/o patch that will be most appreciated. Sean Bruno has already tested this patch at Yahoo, I have just been delayed in committing it. There are just a few small differences so we can commit one or merge. Andrew --f46d042dfdd90c608304ca1e087d Content-Type: application/octet-stream; name="lagg_transmit.diff" Content-Disposition: attachment; filename="lagg_transmit.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h7blxni41 SW5kZXg6IGlmX2xhZ2cuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIGlmX2xhZ2cuYwkocmV2aXNpb24gMjM4 MDQ3KQ0KKysrIGlmX2xhZ2cuYwkod29ya2luZyBjb3B5KQ0KQEAgLTExMCw3ICsxMTAsOCBAQCBz dGF0aWMgaW50CWxhZ2dfZXRoZXJfY21kbXVsdGkoc3RydWN0IGxhZ2dfcG9ydCAqLA0KIHN0YXRp YwlpbnQJbGFnZ19zZXRmbGFnKHN0cnVjdCBsYWdnX3BvcnQgKiwgaW50LCBpbnQsDQogCQkgICAg aW50ICgqZnVuYykoc3RydWN0IGlmbmV0ICosIGludCkpOw0KIHN0YXRpYwlpbnQJbGFnZ19zZXRm bGFncyhzdHJ1Y3QgbGFnZ19wb3J0ICosIGludCBzdGF0dXMpOw0KLXN0YXRpYyB2b2lkCWxhZ2df c3RhcnQoc3RydWN0IGlmbmV0ICopOw0KK3N0YXRpYyBpbnQJbGFnZ190cmFuc21pdChzdHJ1Y3Qg aWZuZXQgKmlmcCwgc3RydWN0IG1idWYgKm0pOw0KK3N0YXRpYyB2b2lkCWxhZ2dfcWZsdXNoKHN0 cnVjdCBpZm5ldCAqaWZwKTsNCiBzdGF0aWMgaW50CWxhZ2dfbWVkaWFfY2hhbmdlKHN0cnVjdCBp Zm5ldCAqKTsNCiBzdGF0aWMgdm9pZAlsYWdnX21lZGlhX3N0YXR1cyhzdHJ1Y3QgaWZuZXQgKiwg c3RydWN0IGlmbWVkaWFyZXEgKik7DQogc3RhdGljIHN0cnVjdCBsYWdnX3BvcnQgKmxhZ2dfbGlu a19hY3RpdmUoc3RydWN0IGxhZ2dfc29mdGMgKiwNCkBAIC0zMTIsMTUgKzMxMywxMiBAQCBsYWdn X2Nsb25lX2NyZWF0ZShzdHJ1Y3QgaWZfY2xvbmUgKmlmYywgaW50IHVuaXQsDQogCWlmX2luaXRu YW1lKGlmcCwgaWZjLT5pZmNfbmFtZSwgdW5pdCk7DQogCWlmcC0+aWZfdHlwZSA9IElGVF9FVEhF UjsNCiAJaWZwLT5pZl9zb2Z0YyA9IHNjOw0KLQlpZnAtPmlmX3N0YXJ0ID0gbGFnZ19zdGFydDsN CisJaWZwLT5pZl90cmFuc21pdCA9IGxhZ2dfdHJhbnNtaXQ7DQorCWlmcC0+aWZfcWZsdXNoID0g bGFnZ19xZmx1c2g7DQogCWlmcC0+aWZfaW5pdCA9IGxhZ2dfaW5pdDsNCiAJaWZwLT5pZl9pb2N0 bCA9IGxhZ2dfaW9jdGw7DQogCWlmcC0+aWZfZmxhZ3MgPSBJRkZfU0lNUExFWCB8IElGRl9CUk9B RENBU1QgfCBJRkZfTVVMVElDQVNUOw0KIA0KLQlJRlFfU0VUX01BWExFTigmaWZwLT5pZl9zbmQs IGlmcW1heGxlbik7DQotCWlmcC0+aWZfc25kLmlmcV9kcnZfbWF4bGVuID0gaWZxbWF4bGVuOw0K LQlJRlFfU0VUX1JFQURZKCZpZnAtPmlmX3NuZCk7DQotDQogCS8qDQogCSAqIEF0dGFjaCBhcyBh biBvcmRpbmFyeSBldGhlcm5ldCBkZXZpY2UsIGNoaWxkcyB3aWxsIGJlIGF0dGFjaGVkDQogCSAq IGFzIHNwZWNpYWwgZGV2aWNlIElGVF9JRUVFODAyM0FETEFHLg0KQEAgLTEyMjIsMzcgKzEyMjAs NDQgQEAgbGFnZ19zZXRmbGFncyhzdHJ1Y3QgbGFnZ19wb3J0ICpscCwgaW50IHN0YXR1cykNCiAJ cmV0dXJuICgwKTsNCiB9DQogDQotc3RhdGljIHZvaWQNCi1sYWdnX3N0YXJ0KHN0cnVjdCBpZm5l dCAqaWZwKQ0KK3N0YXRpYyBpbnQNCitsYWdnX3RyYW5zbWl0KHN0cnVjdCBpZm5ldCAqaWZwLCBz dHJ1Y3QgbWJ1ZiAqbSkNCiB7DQogCXN0cnVjdCBsYWdnX3NvZnRjICpzYyA9IChzdHJ1Y3QgbGFn Z19zb2Z0YyAqKWlmcC0+aWZfc29mdGM7DQotCXN0cnVjdCBtYnVmICptOw0KLQlpbnQgZXJyb3Ig PSAwOw0KKwlpbnQgZXJyb3IsIGxlbiwgbWNhc3Q7DQogDQogCUxBR0dfUkxPQ0soc2MpOw0KIAkv KiBXZSBuZWVkIGEgVHggYWxnb3JpdGhtIGFuZCBhdCBsZWFzdCBvbmUgcG9ydCAqLw0KIAlpZiAo c2MtPnNjX3Byb3RvID09IExBR0dfUFJPVE9fTk9ORSB8fCBzYy0+c2NfY291bnQgPT0gMCkgew0K LQkJSUZfRFJBSU4oJmlmcC0+aWZfc25kKTsNCisJCW1fZnJlZW0obSk7DQogCQlMQUdHX1JVTkxP Q0soc2MpOw0KLQkJcmV0dXJuOw0KKwkJcmV0dXJuICgwKTsNCiAJfQ0KIA0KLQlmb3IgKDs7IGVy cm9yID0gMCkgew0KLQkJSUZRX0RFUVVFVUUoJmlmcC0+aWZfc25kLCBtKTsNCi0JCWlmIChtID09 IE5VTEwpDQotCQkJYnJlYWs7DQorCWxlbiA9IG0tPm1fcGt0aGRyLmxlbjsNCisJbWNhc3QgPSAo bS0+bV9mbGFncyAmIChNX01DQVNUIHwgTV9CQ0FTVCkpID8gMSA6IDA7DQorCUVUSEVSX0JQRl9N VEFQKGlmcCwgbSk7DQogDQotCQlFVEhFUl9CUEZfTVRBUChpZnAsIG0pOw0KKwllcnJvciA9ICgq c2MtPnNjX3N0YXJ0KShzYywgbSk7DQorCWlmIChlcnJvciA9PSAwKSB7DQorCQlpZnAtPmlmX29w YWNrZXRzKys7DQorCQlpZnAtPmlmX29tY2FzdHMgKz0gbWNhc3Q7DQorCQlpZnAtPmlmX29ieXRl cyArPSBsZW47DQorCX0gZWxzZQ0KKwkJaWZwLT5pZl9vZXJyb3JzKys7DQorCUxBR0dfUlVOTE9D SyhzYyk7DQogDQotCQllcnJvciA9ICgqc2MtPnNjX3N0YXJ0KShzYywgbSk7DQotCQlpZiAoZXJy b3IgPT0gMCkNCi0JCQlpZnAtPmlmX29wYWNrZXRzKys7DQotCQllbHNlDQotCQkJaWZwLT5pZl9v ZXJyb3JzKys7DQotCX0NCi0JTEFHR19SVU5MT0NLKHNjKTsNCisJcmV0dXJuIChlcnJvcik7DQog fQ0KIA0KKy8qDQorICogVGhlIGlmcC0+aWZfcWZsdXNoIGVudHJ5IHBvaW50IGZvciBsYWdnKDQp IGlzIGEgbm8tb3AuDQorICovDQorc3RhdGljIHZvaWQNCitsYWdnX3FmbHVzaChzdHJ1Y3QgaWZu ZXQgKmlmcCBfX3VudXNlZCkNCit7DQorfQ0KKw0KIHN0YXRpYyBzdHJ1Y3QgbWJ1ZiAqDQogbGFn Z19pbnB1dChzdHJ1Y3QgaWZuZXQgKmlmcCwgc3RydWN0IG1idWYgKm0pDQogew0K --f46d042dfdd90c608304ca1e087d--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFAOGNTE_HO4TScR0ztUihbs%2BfXeP6_jENvWTcnudK65J=1%2B-Q>