Date: Thu, 28 Apr 2022 15:25:15 +0200 From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernape@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: "ports-committers@FreeBSD.org" <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 930715f767cc - main - editors/rehex: update to 0.5.0 Message-ID: <CAGwOe2a0CJ3e0UrU2AyJ0ODLLy7iaW66ij9cPa8En4sT0z8P4w@mail.gmail.com> In-Reply-To: <YmoyjyXPRphzGr7P@FreeBSD.org> References: <202204280601.23S61YQQ010774@gitrepo.freebsd.org> <YmoyjyXPRphzGr7P@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 28, 2022 at 8:22 AM Alexey Dokuchaev <danfe@freebsd.org> wrote:
>
> On Thu, Apr 28, 2022 at 06:01:34AM +0000, Fernando Apestegu??a wrote:
> > commit 930715f767ccfb6375ee7c56f7ba3134541593de
> >
> > editors/rehex: update to 0.5.0
> >
> > -MAKE_ENV= LUA_PKG="lua-${LUA_VER}" LUA="${LUA_CMD}"
> > +MAKE_ENV= LUA_PKG="lua-${LUA_VER}" LUA="${LUA_CMD}" STRIP="${STRIP}"
>
> So now you have to pass STRIP explicitly...
>
> > - install -D -m 0755 $(EXE) $(DESTDIR)$(bindir)/$(EXE)
> > -+ $(BSD_INSTALL_PROGRAM) $(EXE) $(DESTDIR)$(bindir)/$(EXE)
> > ++ install -m 0755 $(STRIP) $(EXE) $(DESTDIR)$(bindir)/$(EXE)
>
> ... to use it here, but BSD_INSTALL_PROGRAM already does it automagically,
> why remove it and set the Sun by hands?
>
> > -+ $(BSD_INSTALL_DATA) res/icon$${s}.png $(DESTDIR)$(datarootdir)/icons/hicolor/$${s}x$${s}/apps/rehex.png; \
> > ++ install -m 0644 res/icon$${s}.png $(DESTDIR)$(datarootdir)/icons/hicolor/$${s}x$${s}/apps/rehex.png; \
>
> Ditto for BSD_INSTALL_DATA here and below.
I've asked the maintainer about this. I reverted the change locally
and rebuilt 0.4.1 and I don't see any warnings about not stripped
files.
Thanks for pointing this out.
>
> ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGwOe2a0CJ3e0UrU2AyJ0ODLLy7iaW66ij9cPa8En4sT0z8P4w>