From owner-freebsd-current@FreeBSD.ORG Mon Nov 17 18:37:57 2008 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1B32C1065677 for ; Mon, 17 Nov 2008 18:37:57 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello087206045082.chello.pl [87.206.45.82]) by mx1.freebsd.org (Postfix) with ESMTP id 7BA928FC18 for ; Mon, 17 Nov 2008 18:37:56 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id AAC5A4569A; Mon, 17 Nov 2008 19:37:54 +0100 (CET) Received: from localhost (unknown [216.239.45.19]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 4F22345684; Mon, 17 Nov 2008 19:37:48 +0100 (CET) Date: Mon, 17 Nov 2008 19:37:45 +0100 From: Pawel Jakub Dawidek To: Doug Rabson Message-ID: <20081117183745.GB1733@garage.freebsd.pl> References: <20081117171017.GB1489@garage.freebsd.pl> <4AC8E131-CD12-4075-948F-DA187B4EE2AD@rabson.org> <20081117180253.GA1733@garage.freebsd.pl> <8A43CF07-D06F-4EAF-A171-DF7F10F036F5@rabson.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="neYutvxvOLaeuPCA" Content-Disposition: inline In-Reply-To: <8A43CF07-D06F-4EAF-A171-DF7F10F036F5@rabson.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00 autolearn=ham version=3.0.4 Cc: freebsd-current@FreeBSD.org Subject: Re: NFS regression. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Nov 2008 18:37:57 -0000 --neYutvxvOLaeuPCA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 17, 2008 at 06:07:52PM +0000, Doug Rabson wrote: >=20 > On 17 Nov 2008, at 18:02, Pawel Jakub Dawidek wrote: >=20 > >On Mon, Nov 17, 2008 at 05:54:02PM +0000, Doug Rabson wrote: > >> > >>On 17 Nov 2008, at 17:10, Pawel Jakub Dawidek wrote: > >> > >>>Hi. > >>> > >>>I'm seeing this panic very often now with few days old HEAD: > >>> > >>> > >>>Any ideas? > >> > >>Can you reproduce this with INVARIANTS turned on? That should trigger > >>a KASSERT a bit earlier and give me a chance to fix the thing. > > > >I've INVARIANTS on... Is there some assertion added recently you are > >expecting? >=20 > Hmm. I added an assert in r184921 which ought to have caught this. =20 > Could you try this patch and see if it changes anything: >=20 > Index: rpc/clnt_dg.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- rpc/clnt_dg.c (revision 184968) > +++ rpc/clnt_dg.c (working copy) > @@ -543,7 +543,7 @@ >=20 > if (tv > 0) { > if (cu->cu_closing || cu->cu_closed) > - error =3D 0; > + error =3D ESHUTDOWN; > else > error =3D msleep(cr, &cs->cs_lock, > cu->cu_waitflag, cu->cu_waitchan, tv); >=20 Ok, my source is older and doesn't contain the assertion you added. I applied the patch above and also added assertion by hand (I'm not setup now to upgrade entire system). This is the panic I get with the new kernel: panic: xdrmbuf_create with NULL mbuf chain cpuid =3D 0 KDB: enter: panic [thread pid 1017 tid 100086 ] Stopped at kdb_enter+0x3a: movl $0,kdb_why db> tr Tracing pid 1017 tid 100086 td 0x841fa480 kdb_enter(80686620,80686620,806a1861,83b52714,0,...) at kdb_enter+0x3a panic(806a1861,83b527e8,805c6746,83b527b4,0,...) at panic+0x136 xdrmbuf_create(83b527b4,0,1,2a3,bb9,...) at xdrmbuf_create+0x1f clnt_dg_call(83dffca0,83b5287c,2,84042600,83b528b8,...) at clnt_dg_call+0xc= a6 clnt_reconnect_call(83dffcc0,83b5287c,2,84042600,83b528b8,...) at clnt_reco= nnect_call+0x5a0 nfs_request(85173648,84042600,2,841fa480,8432d200,...) at nfs_request+0x1dd nfs_setattrrpc(83b52a90,83b529f4,83b529e8,83b529f8,83b529e8,...) at nfs_set= attrrpc+0x24b nfs_create(83b52acc,83b52acc,0,83b52acc,83b52ba8,...) at nfs_create+0x530 VOP_CREATE_APV(806cfea0,83b52acc,2,804cf1cc,8432d200,...) at VOP_CREATE_APV= +0xa5 vn_open_cred(83b52ba8,83b52c5c,180,8432d200,84105268,...) at vn_open_cred+0= x1d0 vn_open(83b52ba8,83b52c5c,180,84105268,6fc8a6,...) at vn_open+0x33 kern_openat(841fa480,ffffff9c,7fbfdd34,0,a03,...) at kern_openat+0xe0 kern_open(841fa480,7fbfdd34,0,a02,180,...) at kern_open+0x35 open(841fa480,83b52cf8,c,804d150,806bab18,...) at open+0x30 syscall(83b52d38) at syscall+0x283 Xint0x80_syscall() at Xint0x80_syscall+0x20 --- syscall (5, FreeBSD ELF32, open), eip =3D 0x807e147, esp =3D 0x7fbfd82c= , ebp =3D 0x7fbfdcd8 --- If you want me to convert some of those to file:line, just let me know. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --neYutvxvOLaeuPCA Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFJIbn4ForvXbEpPzQRAg9zAKDfU1MUZN6wc0CG2qurYnYF/PkMWACg56Qe FlaZO2muNTfK7/t7D+H9DzU= =lmaC -----END PGP SIGNATURE----- --neYutvxvOLaeuPCA--