From owner-cvs-all@FreeBSD.ORG Thu May 1 21:20:16 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6F21F106567E for ; Thu, 1 May 2008 21:20:16 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.185]) by mx1.freebsd.org (Postfix) with ESMTP id 8E3C28FC31 for ; Thu, 1 May 2008 21:20:14 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: by nf-out-0910.google.com with SMTP id h3so571485nfh.33 for ; Thu, 01 May 2008 14:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:sender; bh=iGcQ2vWvBFped2D/jbh4ch/TUNxOr/pgJIrnYbisfWw=; b=xPDo3/z3KfPrTBdZyn47ummzABRQGmthJXm4+sxbJsmw0zexY7Jt/HA+AQVI3eYbH3SoHHbqvkLl9QDkf+ZGZI0fwR0DNi7osF5iVp3XrOzMefQR0Vfo6HF0Wow/jwse8BLNV2CwswveBJafdhGp75qVDVs2GbTzoVFYU2gZkHE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:sender; b=B9pJMFXFH9uhGlWXJcSZKiRwkghbAtE3pRxwY280VIWgUgai6VoyFi/rYdgLalRJ/M0RGPc818VAuMQT/1UwUVfi/Zp6P+ZijSTKulnTrDS5MzaKw7bC/5ScZQAAj1pZsSDHUv7kfSbmBmwL4i7DDfrMS95QuNqHrZrPUW1F7fg= Received: by 10.210.58.17 with SMTP id g17mr2334580eba.190.1209676812669; Thu, 01 May 2008 14:20:12 -0700 (PDT) Received: from epsilon.local ( [89.214.145.245]) by mx.google.com with ESMTPS id f4sm12837334nfh.0.2008.05.01.14.20.10 (version=SSLv3 cipher=RC4-MD5); Thu, 01 May 2008 14:20:11 -0700 (PDT) Message-ID: <481A3406.8080007@FreeBSD.org> Date: Thu, 01 May 2008 22:20:06 +0100 From: Rui Paulo User-Agent: Thunderbird 2.0.0.12 (Macintosh/20080213) MIME-Version: 1.0 To: John Baldwin References: <200802281910.m1SJAgm1083976@repoman.freebsd.org> <200805011547.07007.jhb@freebsd.org> In-Reply-To: <200805011547.07007.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: Rui Paulo Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/cpufreq est.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 May 2008 21:20:16 -0000 John Baldwin wrote: > On Thursday 28 February 2008 02:10:42 pm Rui Paulo wrote: >> rpaulo 2008-02-28 19:10:42 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/i386/cpufreq est.c >> Log: >> Validate the id16 values gathered from ACPI (previously a TODO item). >> Style changes by me and njl. > > What is the purpose of the 'saved_id16' variable? It is never used. I think > what might be better is to just read it once at the start of the loop and > then restore it at the end of the loop, though phk@ has overwritten this with > the "chew up all battery on laptops at all cost" patch. :-P > What do you mean by 'It is never used.' ? % cat -n est.c | grep saved_id16 1082 uint16_t saved_id16; 1111 est_get_id16(&saved_id16); -- Rui Paulo