From owner-freebsd-hackers@FreeBSD.ORG Mon Nov 22 23:08:11 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 19A4C106564A; Mon, 22 Nov 2010 23:08:11 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 6FD378FC12; Mon, 22 Nov 2010 23:08:10 +0000 (UTC) Received: by fxm19 with SMTP id 19so5603143fxm.13 for ; Mon, 22 Nov 2010 15:08:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=ABtR66Jg+m2xo+/VR2jZSziXfifmvr1F/dzoQ029mHA=; b=ua8FJXkWUTHDbE89Y1X/mT8FGfwTcmIMPkBBFWzGmbgAXQG3Iae0eETVPVSXC/NecH lYw/xGgfDlEnjb6fAqVH98lS3LzI862IWji9fjy8F9B4H5GiF97r4dzgzNDQd9VCPJYT uVYceT7p8FjV2ddGo0H9xMLqm2JoJdmUKmSkE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=G0p3QO9yo8QJ5fxb6UiAxuSp7hgNOaT03zz/232M3BcnBNNgl+mtwjODgh7IpsW5Ab mRKoJd+C/rwyn8UMZAEG4SYsx5uWf+Av64WKHssG+lC90tbvetd1kHfoiYys1L5/futM lGImTn97vob+CQ9zZKYAYuFM4uC3MREEQf6KE= Received: by 10.223.97.73 with SMTP id k9mr4857125fan.120.1290467288828; Mon, 22 Nov 2010 15:08:08 -0800 (PST) Received: from mavbook.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id n1sm403637fam.16.2010.11.22.15.08.05 (version=SSLv3 cipher=RC4-MD5); Mon, 22 Nov 2010 15:08:06 -0800 (PST) Sender: Alexander Motin Message-ID: <4CEAF7D1.8050505@FreeBSD.org> Date: Tue, 23 Nov 2010 01:08:01 +0200 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.12) Gecko/20101104 Thunderbird/3.1.6 MIME-Version: 1.0 To: Artem Belevich References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Bruce Cran , Alexander Best , freebsd-hackers@freebsd.org Subject: Re: Another small error. Re: Logical vs. bitwise AND in sbin/routed/parms.c X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2010 23:08:11 -0000 On 23.11.2010 00:07, Artem Belevich wrote: > While it's not directly related to hunting for '&'/'&&' typos, here's > another seemingly wrong place in the code: > > --- a/sys/dev/ahci/ahci.c > +++ b/sys/dev/ahci/ahci.c > @@ -852,7 +852,7 @@ ahci_ch_attach(device_t dev) > ch->caps = ctlr->caps; > ch->caps2 = ctlr->caps2; > ch->quirks = ctlr->quirks; > - ch->numslots = ((ch->caps& AHCI_CAP_NCS)>> AHCI_CAP_NCS_SHIFT) + 1, > + ch->numslots = ((ch->caps& AHCI_CAP_NCS)>> AHCI_CAP_NCS_SHIFT) + 1; > mtx_init(&ch->mtx, "AHCI channel lock", NULL, MTX_DEF); > resource_int_value(device_get_name(dev), > device_get_unit(dev), "pm_level",&ch->pm_level); > > I did mention it on freebsd-current@ some time back: > http://lists.freebsd.org/pipermail/freebsd-current/2009-November/013645.html Fixed at r215725. Thanks. -- Alexander Motin