From owner-svn-src-head@freebsd.org Thu Jul 5 15:54:26 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F2C411035C16; Thu, 5 Jul 2018 15:54:25 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5594D84019; Thu, 5 Jul 2018 15:54:25 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w65FsHMg079546 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 5 Jul 2018 18:54:20 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w65FsHMg079546 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w65FsH1C079545; Thu, 5 Jul 2018 18:54:17 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 5 Jul 2018 18:54:17 +0300 From: Konstantin Belousov To: John Baldwin Cc: Matt Macy , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335916 - head/sys/conf Message-ID: <20180705155417.GI5562@kib.kiev.ua> References: <201807032305.w63N5guY063293@repo.freebsd.org> <20180704142233.GB5562@kib.kiev.ua> <6e5bc5e4-052c-877f-1c36-c72e276ff045@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e5bc5e4-052c-877f-1c36-c72e276ff045@FreeBSD.org> User-Agent: Mutt/1.10.0 (2018-05-17) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 15:54:26 -0000 On Thu, Jul 05, 2018 at 07:56:22AM -0700, John Baldwin wrote: > On 7/4/18 7:22 AM, Konstantin Belousov wrote: > > On Tue, Jul 03, 2018 at 11:05:42PM +0000, Matt Macy wrote: > >> Author: mmacy > >> Date: Tue Jul 3 23:05:42 2018 > >> New Revision: 335916 > >> URL: https://svnweb.freebsd.org/changeset/base/335916 > >> > >> Log: > >> Enable MODULE_TIED by default for modules compiled with the kernel > > But why ? > > I think we should enable KLD_TIED to inline critical_* etc. for modules > built as part of a kernel that are installed alongside the kernel in /boot/. > I don't think we need to support modules built with kernel A loaded into kernel B. > This is the crusial point. I do not object, but this this is a radical change from the previous mode of modules build. I do not want to put words in other person mouth, but I beliee that the original intent of KLD_TIED/MODULE_TIED was much more limited. Only some specific modules were to be tied. > I think we should not enable it for "standalone" module builds done in ports or via > "cd /sys/modules/foo; make" that install to /boot/modules so that those modules can > work with different kernels. This still permits someone to load a module into kernel > A that they had disabled in kernel A's config file (via NO_MODULES or MODULES_OVERRIDE > or some such) by doing 'cd /sys/modules/foo; make; make load'. > > -- > John Baldwin