From owner-freebsd-current Thu Jan 28 02:18:27 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id CAA22159 for freebsd-current-outgoing; Thu, 28 Jan 1999 02:18:27 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from hda.hda.com (hda-bicnet.bicnet.net [209.244.238.132] (may be forged)) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id CAA22151 for ; Thu, 28 Jan 1999 02:18:22 -0800 (PST) (envelope-from dufault@hda.hda.com) Received: (from dufault@localhost) by hda.hda.com (8.8.5/8.8.5) id FAA10811; Thu, 28 Jan 1999 05:12:25 -0500 (EST) From: Peter Dufault Message-Id: <199901281012.FAA10811@hda.hda.com> Subject: Re: btokup() macro in sys/malloc.h In-Reply-To: <199901280629.XAA26798@mt.sri.com> from Nate Williams at "Jan 27, 99 11:29:37 pm" To: nate@mt.sri.com (Nate Williams) Date: Thu, 28 Jan 1999 05:12:24 -0500 (EST) Cc: dillon@apollo.backplane.com, nate@mt.sri.com, archie@whistle.com, wollman@khavrinen.lcs.mit.edu, current@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL25 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > A warning is just that. It's not an error, so don't treat it like one. I use different productions to enable different warnings on code with different histories. For one thing, new revs of the compiler will otherwise cause trouble when the warning behavior changes. I also use -Werror. Eliminating warnings is almost pointless without this. And yeah, I have a NO_WERROR flag for when I'm in a rush. I know -Werror is the eventual goal. So I disagree with Nate about ignoring warnings you've enabled - it is too easy to ignore a new problem. I agree with him that gratuitous casts and similar fixes during damn-the-torpedos mass conversions of large bodies of code are bad in that they can effectively hide latent problems more deeply than they were hidden before such a conversion. So IMHO: Eliminating warnings is good; Any mechanistic change to eliminate warnings that can mask problems can not be used. Peter -- Peter Dufault (dufault@hda.com) Realtime development, Machine control, HD Associates, Inc. Safety critical systems, Agency approval To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message