From owner-svn-src-all@FreeBSD.ORG Thu Sep 2 21:39:54 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F27B710657DD; Thu, 2 Sep 2010 21:39:53 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id 20FD58FC21; Thu, 2 Sep 2010 21:39:42 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id A964A45E11; Thu, 2 Sep 2010 23:39:40 +0200 (CEST) Received: from localhost (chello089077043238.chello.pl [89.77.43.238]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 9918B45CDD; Thu, 2 Sep 2010 23:39:35 +0200 (CEST) Date: Thu, 2 Sep 2010 23:39:26 +0200 From: Pawel Jakub Dawidek To: "Justin T. Gibbs" Message-ID: <20100902213926.GA2542@garage.freebsd.pl> References: <201009021940.o82JeS8M017537@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4Ckj6UjgE2iN1+kY" Content-Disposition: inline In-Reply-To: <201009021940.o82JeS8M017537@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212160 - in head/sys: cam/ata cam/scsi cddl/contrib/opensolaris/uts/common/fs/zfs geom geom/sched kern sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Sep 2010 21:39:54 -0000 --4Ckj6UjgE2iN1+kY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 02, 2010 at 07:40:28PM +0000, Justin T. Gibbs wrote: > Author: gibbs > Date: Thu Sep 2 19:40:28 2010 > New Revision: 212160 > URL: http://svn.freebsd.org/changeset/base/212160 >=20 > Log: > Correct bioq_disksort so that bioq_insert_tail() offers barrier semanti= c. Thank you for working on this, Justin! > sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c > sys/geom/geom_io.c > Mark bios with the BIO_FLUSH command as BIO_ORDERED. [...] Don't you think it would be better to set the flag from within g_io_request()? This way every BIO_FLUSH consumer doesn't have to remember to set it. Or am I missing something? --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --4Ckj6UjgE2iN1+kY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkyAGY4ACgkQForvXbEpPzQ3gwCdF0QP84b130HXi+HoDuk2ppKw kv4Anj3WqnLR8uTTKBkrTdnyH0MR9gor =4+At -----END PGP SIGNATURE----- --4Ckj6UjgE2iN1+kY--