From owner-svn-src-all@FreeBSD.ORG Fri Mar 25 16:38:10 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CF3181065673; Fri, 25 Mar 2011 16:38:10 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id BF6E58FC16; Fri, 25 Mar 2011 16:38:10 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id p2PGcAEp087101; Fri, 25 Mar 2011 16:38:10 GMT (envelope-from kib@svn.freebsd.org) Received: (from kib@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id p2PGcAWa087099; Fri, 25 Mar 2011 16:38:10 GMT (envelope-from kib@svn.freebsd.org) Message-Id: <201103251638.p2PGcAWa087099@svn.freebsd.org> From: Konstantin Belousov Date: Fri, 25 Mar 2011 16:38:10 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r220001 - head/sys/vm X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2011 16:38:10 -0000 Author: kib Date: Fri Mar 25 16:38:10 2011 New Revision: 220001 URL: http://svn.freebsd.org/changeset/base/220001 Log: Handle the corner case in vm_fault_quick_hold_pages(). If supplied length is zero, and user address is invalid, function might return -1, due to the truncation and rounding of the address. The callers interpret the situation as EFAULT. Instead of handling the zero length in caller, filter it in vm_fault_quick_hold_pages(). Sponsored by: The FreeBSD Foundation Reviewed by: alc Modified: head/sys/vm/vm_fault.c Modified: head/sys/vm/vm_fault.c ============================================================================== --- head/sys/vm/vm_fault.c Fri Mar 25 14:01:18 2011 (r220000) +++ head/sys/vm/vm_fault.c Fri Mar 25 16:38:10 2011 (r220001) @@ -1058,6 +1058,8 @@ vm_fault_quick_hold_pages(vm_map_t map, int count; boolean_t pmap_failed; + if (len == 0) + return (0); end = round_page(addr + len); addr = trunc_page(addr);