Date: Tue, 27 Jan 2004 16:03:43 +0100 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Lukas Ertl <l.ertl@univie.ac.at> Cc: freebsd-geom@freebsd.org Subject: Re: Error checking for g_mod_event() and friends Message-ID: <4926.1075215823@critter.freebsd.dk> In-Reply-To: Your message of "Tue, 27 Jan 2004 16:01:53 %2B0100." <20040127160001.N92925@pcle2.cc.univie.ac.at>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20040127160001.N92925@pcle2.cc.univie.ac.at>, Lukas Ertl writes: >On Tue, 27 Jan 2004, Poul-Henning Kamp wrote: > >> In message <20040127154303.E92925@pcle2.cc.univie.ac.at>, Lukas Ertl writes: >> >Hi, >> > >> >is there a specific reason that the .init function of a class is declared >> >to return "void"? I'd like to change that to an int, so we could do error >> >checking, and subsequently modify g_load_class() to check for errors and >> >so on. >> >> In what circumstances would class->init() fail ? > >In the geom_vinum case I allocate the "main" vinum geom in the init >method, and this might fail. > >(Of course, this might not be the correct way to do it, but I couldn't >think of another way.) You're right, it isn't :-) You should never allocate anything until you first time taste a disk which looks like yours. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4926.1075215823>