Date: Tue, 4 Oct 2022 15:35:25 +0200 From: Gary Jennejohn <garyj@gmx.de> To: Hans Petter Selasky <hps@selasky.org> Cc: Johan Hendriks <joh.hendriks@gmail.com>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: build world fails on raw_ip.c Message-ID: <20221004153525.7a31a62d@ernst.home> In-Reply-To: <b16cc891-dfb3-f05d-c36d-4a336664dbd3@selasky.org> References: <c63a0481-6f60-729a-56c0-1da96d8b6be9@gmail.com> <b16cc891-dfb3-f05d-c36d-4a336664dbd3@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 4 Oct 2022 15:20:05 +0200
Hans Petter Selasky <hps@selasky.org> wrote:
> On 10/4/22 15:14, Johan Hendriks wrote:
> > I just updated the source today but now i get an error building world.
> > The old build was from yesterday which was fine!
> >
> > Building /usr/obj/usr/src/amd64.amd64/sys/KRNL/raw_ip.o
> > cc -target x86_64-unknown-freebsd14.0 > --sysroot=3D/usr/obj/usr/src/a=
md64.amd64/tmp > -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin -c -O2 -pipe >=
-fno-strict-aliasing -march=3Dbroadwell -g -nostdinc=A0 -I. -I/usr/src/sy=
s > -I/usr/src/sys/contrib/ck/include -I/usr/src/sys/contrib/libfdt > -D_K=
ERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common > -fn=
o-omit-frame-pointer -mno-omit-leaf-frame-pointer > -fdebug-prefix-map=3D.=
/machine=3D/usr/src/sys/amd64/include > -fdebug-prefix-map=3D./x86=3D/usr/=
src/sys/x86/include > -fdebug-prefix-map=3D./i386=3D/usr/src/sys/i386/incl=
ude -mcmodel=3Dkernel > -mno-red-zone -mno-mmx -mno-sse -msoft-float > -fn=
o-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector > -W=
all -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes > -Wpointer-=
arith -Wcast-qual -Wundef -Wno-pointer-sign > -D__printf__=3D__freebsd_kpr=
intf__ -Wmissing-include-dirs > -fdiagnostics-show-option -Wno-unknown-pra=
gmas > -Wno-error=3Dtautological-compare -Wno-error=3Dempty-body > -Wno-er=
ror=3Dparentheses-equality -Wno-error=3Dunused-function > -Wno-error=3Dpoi=
nter-sign -Wno-error=3Dshift-negative-value > -Wno-address-of-packed-membe=
r -Wno-format-zero-length=A0=A0 -mno-aes > -mno-avx=A0 -std=3Diso9899:1999=
-Werror /usr/src/sys/netinet/raw_ip.c
> > /usr/src/sys/netinet/raw_ip.c:811:3: error: too few arguments to > fun=
ction call, expected 4, have 2
> > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 IPSEC_CTLINPUT(ipv4, ic=
mp);
> > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ^~~~~~~~~~~~~~~~~~~~~~~=
~~~
> > /usr/src/sys/netipsec/ipsec_support.h:222:61: note: expanded from macr=
o > 'IPSEC_CTLINPUT'
> > =A0=A0=A0 ipsec_kmod_ctlinput(proto ## _ipsec_support, __VA_ARGS__)
> > =A0=A0=A0 ~~~~~~~~~~~~~~~~~~~=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ^
> > /usr/src/sys/netipsec/ipsec_support.h:196:5: note: 'ipsec_kmod_ctlinpu=
t' > declared here
> > int ipsec_kmod_ctlinput(struct ipsec_support * const, int,
> > =A0=A0=A0 ^
> > 1 error generated.
> > *** Error code 1
> >
>
> I've mailed the responsible committer.
>
> Just do:
>
> diff --git a/sys/amd64/conf/GENERIC b/sys/amd64/conf/GENERIC
> index 9178abba36cc..ed8045e48257 100644
> --- a/sys/amd64/conf/GENERIC
> +++ b/sys/amd64/conf/GENERIC
> @@ -30,7 +30,7 @@ options PREEMPTION # Enable kernel =
thread preemption
> options VIMAGE # Subsystem virtualization, e.g=
. VNET
> options INET # InterNETworking
> options INET6 # IPv6 communications protocols
> -options IPSEC_SUPPORT # Allow kldload of ipsec and tcp=
md5
> +# options IPSEC_SUPPORT # Allow kldload of ipsec and tcp=
md5
> options ROUTE_MPATH # Multipath routing sup=
port
> options FIB_ALGO # Modular fib lookups
> options TCP_OFFLOAD # TCP offload
>
>
>
> For now.
>
There are the usual other problems, like always assuming the every user
has INET6 defined in their kernel config file.
Here's an error I just saw:
/usr/src/sys/netinet/tcp_subr.c:136:8: error: unknown type name 'ip6proto_=
ctlinput_t'; did you mean 'ipproto_ctlinput_t'?
static ip6proto_ctlinput_t tcp6_ctlinput;
^~~~~~~~~~~~~~~~~~~
ipproto_ctlinput_t
/usr/src/sys/netinet/ip_var.h:242:14: note: 'ipproto_ctlinput_t' declared =
here
typedef void ipproto_ctlinput_t(struct icmp *);
^
1 error generated.
=2D-- tcp_subr.o ---
*** [tcp_subr.o] Error code 1
=2D-
Gary Jennejohn
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20221004153525.7a31a62d>