From owner-svn-src-head@freebsd.org Fri Mar 13 18:28:23 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 83BA7267107; Fri, 13 Mar 2020 18:28:23 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48fDj11468z4RM1; Fri, 13 Mar 2020 18:28:21 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-qk1-f180.google.com with SMTP id x1so9349063qkx.10; Fri, 13 Mar 2020 11:28:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8SqRKOl6OvXqwkK09UanR9pQqkGP9nsazut/7vMBn+M=; b=i9rncCYFZA/pJH1WPhlFEqwOuQjMVcv+lvqf73q7fWVhVME5D73SzmE4yDEwaG036W sQvmGNhAxvXALzzdRaR+o4E5wkMH8sv0b30MlaX0ToT6H/5z7D+jD1uYz/3oyrwCVljc IFx9h8y2S5LrRjfNlDPeW2gPEBbhni1Az8Ib9m7MShs+/Kt0+LlHftVjsa8deDRdD7ed BZfXgm9hIzHDSq1L6pOm22haZ1rxgFpRcBwss99ZGSz3q0ywtvSoRzED68BXxBYHie2x p2Jq08eshcPmnskXGuqpqZbGQbcSnaul9tmc3uHXPCdW5opnuy5Y3Rn6mCkd7TnbP7W6 j5Xw== X-Gm-Message-State: ANhLgQ1dea6xD0FExUz9XUCSguxW/9Uq7pa+tcYCq1C49B4sLGDb1ZUR 9wuWRDNrlUIx7shUnhKBaP25LkNrgNUod2qu1CFAtg== X-Google-Smtp-Source: ADFU+vvFl4TdMU5opkzIXQp4Woo6jjBKPujHekjNyiI6KNQSWqxgWK2TsyAzMr9kWxTt5CPTH1BIXOlrEugkxOu10rE= X-Received: by 2002:a25:785:: with SMTP id 127mr19271053ybh.405.1584124098542; Fri, 13 Mar 2020 11:28:18 -0700 (PDT) MIME-Version: 1.0 References: <201911110506.xAB56nFV057050@repo.freebsd.org> <1cc79883-382f-dcad-ce0d-f8e26232e394@FreeBSD.org> In-Reply-To: <1cc79883-382f-dcad-ce0d-f8e26232e394@FreeBSD.org> From: Li-Wen Hsu Date: Sat, 14 Mar 2020 02:28:02 +0800 Message-ID: Subject: Re: svn commit: r354606 - in head: contrib/jemalloc contrib/jemalloc/doc contrib/jemalloc/include/jemalloc contrib/jemalloc/include/jemalloc/internal contrib/jemalloc/src lib/libc/stdlib/jemalloc To: Bryan Drewery , Jason Evans Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 48fDj11468z4RM1 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of lwhsufreebsd@gmail.com designates 209.85.222.180 as permitted sender) smtp.mailfrom=lwhsufreebsd@gmail.com X-Spamd-Result: default: False [-3.58 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_NEQ_ENVFROM(0.00)[lwhsu@freebsd.org,lwhsufreebsd@gmail.com]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[5]; IP_SCORE(-1.58)[ip: (-3.23), ipnet: 209.85.128.0/17(-2.97), asn: 15169(-1.65), country: US(-0.05)]; TO_DN_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[180.222.85.209.list.dnswl.org : 127.0.5.0]; FORGED_SENDER(0.30)[lwhsu@freebsd.org,lwhsufreebsd@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[180.222.85.209.rep.mailspike.net : 127.0.0.17]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Mar 2020 18:28:23 -0000 I think it's fine to get jemalloc 5.2.1 in again now. The previous fails were due to ancient gcc421. Now the in-tree gcc has been removed and the default compiler of non-llvm platforms are all using gcc6 from ports. The CI environment are also updated to follow the current standard. I've tested a patch combines r354605 + r355975 and it builds fine on amd64 (clang10) and mips (gcc6). Best, Li-Wen On Thu, Jan 9, 2020 at 1:45 PM Bryan Drewery wrote: > > Do you plan to get this back in soon? I hope to see it before 12.2 if > possible. Is there some way I can help? > > I'm interested in these changes in 5.2.1 (I think) > - Properly trigger decay on tcache destroy. (@interwq, @amosbird) > - Fix tcache.flush. (@interwq) > - Fix a side effect caused by extent_max_active_fit combined with > decay-based purging, where freed extents can accumulate and not be > reused for an extended period of time. (@interwq, @mpghf) > > I have a test case where virtual memory was peaking at 275M on 4.x, 1GB > on 5.0.0, around 750M on 5.1.0, and finally 275M again on 5.2.0. The > 5.0/5.1 versions appeared to be a widespread leak to us. > > On 11/10/2019 9:06 PM, Jason Evans wrote: > > Author: jasone > > Date: Mon Nov 11 05:06:49 2019 > > New Revision: 354606 > > URL: https://svnweb.freebsd.org/changeset/base/354606 > > > > Log: > > Revert r354605: Update jemalloc to version 5.2.1. > > > > Compilation fails for non-llvm-based platforms. > > > -- > Regards, > Bryan Drewery >