Date: Sat, 19 Jan 2013 17:12:23 +0000 (UTC) From: Tim Kientzle <kientzle@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r245672 - head/sys/arm/ti Message-ID: <201301191712.r0JHCNch018566@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: kientzle Date: Sat Jan 19 17:12:23 2013 New Revision: 245672 URL: http://svnweb.freebsd.org/changeset/base/245672 Log: Clarify the error messages for unrecognized pins and muxtypes. Modified: head/sys/arm/ti/ti_scm.c Modified: head/sys/arm/ti/ti_scm.c ============================================================================== --- head/sys/arm/ti/ti_scm.c Sat Jan 19 16:22:41 2013 (r245671) +++ head/sys/arm/ti/ti_scm.c Sat Jan 19 17:12:23 2013 (r245672) @@ -155,8 +155,10 @@ ti_scm_padconf_set_internal(struct ti_sc } /* couldn't find the mux mode */ - if (mode >= 8) + if (mode >= 8) { + printf("Invalid mode \"%s\"\n", muxmode); return (EINVAL); + } /* set the mux mode */ reg_val |= (uint16_t)(mode & ti_scm_dev.padconf_muxmode_mask); @@ -391,13 +393,16 @@ ti_scm_padconf_init_from_fdt(struct ti_s while (padstates->state != NULL) { if (strcmp(padstates->state, padstate) == 0) { err = ti_scm_padconf_set_internal(sc, - padconf, muxname, padstates->reg); + padconf, muxname, padstates->reg); } padstates++; } if (err) - device_printf(sc->sc_dev, "err: failed to configure" - "pin \"%s\"\n", padconf->ballname); + device_printf(sc->sc_dev, + "err: failed to configure " + "pin \"%s\" as \"%s\"\n", + padconf->ballname, + muxname); } padconf++; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201301191712.r0JHCNch018566>