From nobody Mon Nov 14 17:21:23 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N9x1Y2RShz4hbtF; Mon, 14 Nov 2022 17:21:37 +0000 (UTC) (envelope-from freebsd@oldach.net) Received: from nuc.oldach.net (hmo.in-vpn.de [IPv6:2001:67c:1407:60::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "nuc.oldach.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N9x1W5VKNz4JBb; Mon, 14 Nov 2022 17:21:35 +0000 (UTC) (envelope-from freebsd@oldach.net) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of freebsd@oldach.net designates 2001:67c:1407:60::1 as permitted sender) smtp.mailfrom=freebsd@oldach.net; dmarc=none Received: from nuc.oldach.net (localhost [127.0.0.1]) by nuc.oldach.net (8.17.1/8.17.1/hmo04jun22) with ESMTPS id 2AEHLOga006566 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 14 Nov 2022 18:21:24 +0100 (CET) (envelope-from freebsd@oldach.net) Received: (from hmo@localhost) by nuc.oldach.net (8.17.1/8.17.1/hmo04jun22/Submit) id 2AEHLOXQ006565; Mon, 14 Nov 2022 18:21:24 +0100 (CET) (envelope-from freebsd@oldach.net) Message-Id: <202211141721.2AEHLOXQ006565@nuc.oldach.net> Subject: Re: git: 5ae69e2f10da - stable/13 - Import the WireGuard driver from zx2c4.com. In-Reply-To: <07fd8a93-b477-43fa-874e-3eabf52486a7@FreeBSD.org> from John Baldwin at "14 Nov 2022 08:55:26" To: jhb@FreeBSD.org (John Baldwin) Date: Mon, 14 Nov 2022 18:21:23 +0100 (CET) Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: freebsd@oldach.net (Helge Oldach) X-No-Archive: Yes List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: inspected by milter-greylist-4.6.4 (nuc.oldach.net [0.0.0.0]); Mon, 14 Nov 2022 18:21:24 +0100 (CET) for IP:127.0.0.1 DOMAIN:localhost HELO:nuc.oldach.net FROM:freebsd@oldach.net RCPT: X-Spamd-Result: default: False [-1.30 / 15.00]; NEURAL_HAM_SHORT(-1.00)[-0.996]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org,dev-commits-src-branches@FreeBSD.org]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_NO_DN(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RCPT_COUNT_THREE(0.00)[4]; ASN(0.00)[asn:29670, ipnet:2001:67c:1400::/45, country:DE]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DMARC_NA(0.00)[oldach.net]; TO_DN_NONE(0.00)[]; RCVD_TLS_LAST(0.00)[] X-Rspamd-Queue-Id: 4N9x1W5VKNz4JBb X-Spamd-Bar: - X-ThisMailContainsUnwantedMimeParts: N John Baldwin wrote on Mon, 14 Nov 2022 17:55:26 +0100 (CET): > On 11/12/22 9:42 AM, Helge Oldach wrote: > > John Baldwin wrote on Fri, 11 Nov 2022 23:04:20 +0100 (CET): > >> The branch stable/13 has been updated by jhb: > >> > >> URL: https://cgit.FreeBSD.org/src/commit/?id=5ae69e2f10dacd750b0f0e9284fefcbe97eb0476 > >> > >> commit 5ae69e2f10dacd750b0f0e9284fefcbe97eb0476 > >> Author: John Baldwin > >> AuthorDate: 2022-10-28 20:36:12 +0000 > >> Commit: John Baldwin > >> CommitDate: 2022-11-11 21:44:11 +0000 > >> > >> Import the WireGuard driver from zx2c4.com. > > > > Is perhaps an #include missing in if_wg.c? > > > > I'm getting below error on stable/13-n252920-0baacb12181. After manually adding said header include, it compiles cleanly. > > Do you have a custom kernel config? Sort of: include MINIMAL nooption XENHVM nodevice xenpci /etc/src.conf has: WITHOUT_CLEAN= WITHOUT_DEBUG_FILES= WITHOUT_KERNEL_SYMBOLS= WITHOUT_SENDMAIL= WITHOUT_TESTS= That's all. I ran a make buildworld buildkernel with empty OBJDIR and that complained at exactly the same step (and continued flawlessly once I added said #include). I have noticed that the if_wg.c on git.zx2c4.com/wireguard-freebsd *has* an #include . I'm seeing the same behaviour on 3 different amd64 machines. One is stable/13-n253075-2b20cade1eca, two are stable/13-n252920-0baacb12181. Kind regards Helge