From owner-svn-src-all@FreeBSD.ORG  Thu Apr 15 21:27:35 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6FAEA106566B;
	Thu, 15 Apr 2010 21:27:35 +0000 (UTC) (envelope-from das@FreeBSD.ORG)
Received: from zim.MIT.EDU (ZIM.MIT.EDU [18.95.3.101])
	by mx1.freebsd.org (Postfix) with ESMTP id E82C98FC14;
	Thu, 15 Apr 2010 21:27:34 +0000 (UTC)
Received: from zim.MIT.EDU (localhost [127.0.0.1])
	by zim.MIT.EDU (8.14.3/8.14.2) with ESMTP id o3FLRYl1017309;
	Thu, 15 Apr 2010 17:27:34 -0400 (EDT) (envelope-from das@FreeBSD.ORG)
Received: (from das@localhost)
	by zim.MIT.EDU (8.14.3/8.14.2/Submit) id o3FLRYXR017308;
	Thu, 15 Apr 2010 17:27:34 -0400 (EDT) (envelope-from das@FreeBSD.ORG)
Date: Thu, 15 Apr 2010 17:27:34 -0400
From: David Schultz <das@FreeBSD.ORG>
To: Juli Mallett <jmallett@FreeBSD.ORG>
Message-ID: <20100415212734.GA17239@zim.MIT.EDU>
Mail-Followup-To: Juli Mallett <jmallett@freebsd.org>,
	src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
References: <201003310212.o2V2CO7b063419@svn.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201003310212.o2V2CO7b063419@svn.freebsd.org>
Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG,
	src-committers@FreeBSD.ORG
Subject: Re: svn commit: r205954 - head/include
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Apr 2010 21:27:35 -0000

On Wed, Mar 31, 2010, Juli Mallett wrote:
>   Be like stdlib.h and bring in a wchar_t definition and use it to prototype
>   wcstoimax and wcstoumax, rather than spelling it __wchar_t.  This is necessary
>   to use these functions in C++ where wchar_t is different to __wchar_t and is
>   a built-in type.

I don't think this change is correct for C mode.  POSIX says
wchar_t is *supposed* to be defined by stdlib.h and wchar.h, but
its definition is namespace pollution elsewhere.

>   It may be better to use __wchar_t here and to simply define __wchar_t as being
>   wchar_t in C++ mode rather than to bring in wchar_t

That may be better.