From nobody Fri Dec 10 23:25:11 2021 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E68AD18EA210 for ; Fri, 10 Dec 2021 23:25:17 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J9n7d4gd0z3NTH; Fri, 10 Dec 2021 23:25:17 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mx1.sbone.de (cross.sbone.de [195.201.62.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 68B6D276E0; Fri, 10 Dec 2021 23:25:17 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id AEC298D4A129; Fri, 10 Dec 2021 23:25:15 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 7D346E7085A; Fri, 10 Dec 2021 23:25:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id 7qduCi1jSPGF; Fri, 10 Dec 2021 23:25:13 +0000 (UTC) Received: from nv.sbone.de (nv.sbone.de [IPv6:fde9:577b:c1a9:31::2013:138]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id DC871E70814; Fri, 10 Dec 2021 23:25:12 +0000 (UTC) Date: Fri, 10 Dec 2021 23:25:11 +0000 (UTC) From: "Bjoern A. Zeeb" To: Tomoaki AOKI cc: freebsd-ports@freebsd.org Subject: Re: HEADS-UP: sys/module.h must be included after sys/param.h on main In-Reply-To: <20211211081102.dd26943d03ce3cb7298aa493@dec.sakura.ne.jp> Message-ID: References: <20211211081102.dd26943d03ce3cb7298aa493@dec.sakura.ne.jp> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639178717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zfx+zNGlv511kciLvAPLuHJJIMfAwVauS78rFtY3CWc=; b=Yy6PfRFootfk3KNJjh2jNb0Gr0gjULrz6+dc/Fpc/DzTlCZzg6fDOWf4wjnGJVhVNg17ag G5Es614peEsbien0bJmPXcXdpaXkpZJ7/tOOKbhtLOpBavYsTV2R+TUBS+goyg6CxZ0YFu XzsXmfnePPGI777RolN+ybKH7k7nQtqcOLjfRw2FLrJM1j9L3aUQVMSLfgwGHyUY8MQtOW fIAIa55ZFMmMXnBZ2CXCF4zYm9K0f4Vx61P6Ja7qIAnjniGAKxDOcRcM6MJSNSZOQ9rHM5 TJ11JIR7AGuEr0Jw6Q6fEJ6HEOGRLeXt8AqNIofSVehz7HutoTEuhY7dbC//7g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639178717; a=rsa-sha256; cv=none; b=A9EFbZ+6owHB+wr3S2NQC2QQPL8Ywp2sgiNaDg4P5lUntXCXC0lg0mmIJ6rLWT41JOJ198 JP/XIaJW7gVQb4q83rHy/e1f/cxptF4n9KOmdSpi4ok14uP2f22Abd2iTvZhBKLQto7YhT x+D3QoHw5f/H6Fau1zj92zshEmbolDP36OycsWzqu5kMnjezQXtz9rhP3MBRQIvuzP+mnw o6LsPlzHkOdubkHNsslVGkLFoavfyIqAkhtdPQVWmwrk9CfzhYv2dh/yPRUYxRp+ik3zkC Z5y+Z17gWQ1lFDqDqE+QDDYw7WxH8jVeNI/8t+SeWeYul94I2nHm4ke/HGMCjw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Sat, 11 Dec 2021, Tomoaki AOKI wrote: Hi, > As no one have done heads-up... > > On src, "git: df38ada2931f - main - modules: increase MAXMODNAME and > provide backward compat" [1] mandates includes of sys/module.h after > sys/param.h. That order is suggested by style.9 as well; I think we had only one case in base not doing that. Missing param.h was more likely but still minimal. > All modules in base are fixed by the commit itself but modules on ports > are not. I am sorry; I hadn't thought about about the possible build issue there. The major concern on the change was the internal backward compat issue. > Maintainers having any port having kmod need checking and, if affected, > fix it. > > At least, I've bitten by sysutils/acpi_call and x11/nvidia-driver. > For x11/nvidia-driver, I've uploaded patch on already-reported Bug > 260318 [2]. Not yet for sysutils/acpi_call. Thank you for that! I'd hope that's all of them. Is it in both cases include order or is param.h missing at all? > [1] > https://lists.freebsd.org/archives/dev-commits-src-main/2021-December/001971.html > > [2] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=260318 -- Bjoern A. Zeeb r15:7