Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 5 May 2012 11:09:57 -0600
From:      Warner Losh <imp@bsdimp.com>
To:        Nathan Whitehorn <nwhitehorn@FreeBSD.ORG>
Cc:        svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG, Warner Losh <imp@FreeBSD.ORG>
Subject:   Re: svn commit: r235050 - head/sys/arm/arm
Message-ID:  <887183C8-204F-4240-9CA7-E9295B6219B9@bsdimp.com>
In-Reply-To: <4FA552F7.70306@freebsd.org>
References:  <201205050715.q457FZ6v044678@svn.freebsd.org> <4FA552F7.70306@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On May 5, 2012, at 10:19 AM, Nathan Whitehorn wrote:

> On 05/05/12 02:15, Warner Losh wrote:
>> Author: imp
>> Date: Sat May  5 07:15:34 2012
>> New Revision: 235050
>> URL: http://svn.freebsd.org/changeset/base/235050
>>=20
>> Log:
>>   Big endian arm boxes need to have a uname -m of armeb, not arm, so
>>   that the bootstrap from source works correctly.
>>=20
>>   MFC after:	4 days
>>=20
>> Modified:
>>   head/sys/arm/arm/identcpu.c
>>=20
>> Modified: head/sys/arm/arm/identcpu.c
>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>> --- head/sys/arm/arm/identcpu.c	Sat May  5 02:53:19 2012	=
(r235049)
>> +++ head/sys/arm/arm/identcpu.c	Sat May  5 07:15:34 2012	=
(r235050)
>> @@ -52,11 +52,16 @@ __FBSDID("$FreeBSD$");
>>  #include<sys/kernel.h>
>>  #include<sys/sysctl.h>
>>  #include<machine/cpu.h>
>> +#include<machine/endian.h>
>>=20
>>  #include<machine/cpuconf.h>
>>  #include<machine/md_var.h>
>>=20
>> +#if _BYTE_ORDER =3D=3D _LITTLE_ENDIAN
>>  char machine[] =3D "arm";
>> +#else
>> +char machine[] =3D "armeb";
>> +#endif
>>=20
>>  SYSCTL_STRING(_hw, HW_MACHINE, machine, CTLFLAG_RD,
>>          machine, 0, "Machine class");
>=20
> Didn't you mean to change MACHINE_ARCH in /sys/arm/include/param.h? =
Setting MACHINE=3Darmeb will break lots of things, including =
self-hosting.

DOh!  You're right...  I'll fix that. :(

Warner





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?887183C8-204F-4240-9CA7-E9295B6219B9>