From owner-freebsd-bugs@freebsd.org Thu Oct 8 18:33:23 2015 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AF4639D2647 for ; Thu, 8 Oct 2015 18:33:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 82073B37 for ; Thu, 8 Oct 2015 18:33:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t98IXNmE087853 for ; Thu, 8 Oct 2015 18:33:23 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 203644] makefs: Coverity CID 974635, 974636: Copying several struct elements by single memcpy(). Date: Thu, 08 Oct 2015 18:33:23 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: scdbackup@gmx.net X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2015 18:33:23 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203644 Bug ID: 203644 Summary: makefs: Coverity CID 974635, 974636: Copying several struct elements by single memcpy(). Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: scdbackup@gmx.net usr.sbin/makefs/ffs/ffs_bswap.c CID 974635 : Destination buffer too small (BUFFER_SIZE) 10. buffer_size: You might overrun the 48 byte destination string n->di_db by writing the maximum 60 bytes from o->di_db. 138 memcpy(n->di_db, o->di_db, (NDADDR + NIADDR) * sizeof(u_int32_t)); CID 974636 : Destination buffer too small (BUFFER_SIZE) 20. buffer_size: You might overrun the 16 byte destination string n->di_extb by writing the maximum 136 bytes from o->di_extb. 168 memcpy(n->di_extb, o->di_extb, (NXADDR + NDADDR + NIADDR) * 8); --------------- Source analysis: sys/ufs/ufs/dinode.h defines typedef int32_t ufs1_daddr_t; ... struct ufs1_dinode { ... ufs1_daddr_t di_db[NDADDR]; /* 40: Direct disk blocks. */ ufs1_daddr_t di_ib[NIADDR]; /* 88: Indirect disk blocks. */ ... So both arrays get copied in one memcpy() operation. Same with CID 974636: typedef int64_t ufs2_daddr_t; ... struct ufs2_dinode { ... ufs2_daddr_t di_extb[NXADDR];/* 96: External attributes block. */ ufs2_daddr_t di_db[NDADDR]; /* 112: Direct disk blocks. */ ufs2_daddr_t di_ib[NIADDR]; /* 208: Indirect disk blocks. */ Three arrays, one memcpy(). --------------- Remedy proposal: One should consider to use two or three separate memcpy() calls. (I cannot judge whether the alignment of 40 and 88 needs padding bytes on any architecture.) -- You are receiving this mail because: You are the assignee for the bug.