From owner-freebsd-ports@freebsd.org Thu Oct 1 21:21:28 2020 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 77DD84344E5 for ; Thu, 1 Oct 2020 21:21:28 +0000 (UTC) (envelope-from rde@tavi.co.uk) Received: from kipling.tavi.co.uk (kipling.tavi.co.uk [81.187.145.130]) by mx1.freebsd.org (Postfix) with ESMTP id 4C2QzW40V7z3TRg for ; Thu, 1 Oct 2020 21:21:27 +0000 (UTC) (envelope-from rde@tavi.co.uk) Received: from kipling.tavi.co.uk (localhost [127.0.0.1]) by kipling.tavi.co.uk (Postfix) with ESMTP id 8C7B4139D8 for ; Thu, 1 Oct 2020 22:21:19 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=tavi.co.uk; h=date:from:to :subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=selector1; bh=GZdLSTR O4w8C044RNKeyvW9jrIk=; b=iuIpaID5ZxgQB0dNdgndP9ao1xerEKZnI7BRQ8m P8WCW3N4IJ1DWTF9y+oK5pPO3dITjnVFxFDbTjgq1DKeWuI6/ASG0QVQdsX7V7S1 QCAQ4dixc92m+aGYY9cNuoG0iqx270GR+JqCIb28XMLKBwmJ4IXbOe1hy8Z5YIrT 237k= Received: from raksha.tavi.co.uk (raksha.tavi.co.uk [81.187.145.139]) (Authenticated sender: rde@tavi.co.uk) by kipling.tavi.co.uk (Postfix) with ESMTPA id 5B085139D1 for ; Thu, 1 Oct 2020 22:21:19 +0100 (BST) Date: Thu, 1 Oct 2020 22:21:19 +0100 From: Bob Eager To: freebsd-ports@freebsd.org Subject: Re: Patch compiler warnings away? Message-ID: <20201001222119.3011f84e@raksha.tavi.co.uk> In-Reply-To: <20201001211149.uhdi4w6xstjv4iw3@t470.schmi.tt> References: <20201001211149.uhdi4w6xstjv4iw3@t470.schmi.tt> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd12.1) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAMFBMVEUwXjFLc0vD0cS7y7zw9PDZ4tkWSRaVrZZ+m39qi2tXfVj////7+/utwK4IPggAOAAJUUA7AAABKklEQVQ4jWPYjQMwDFYJp0NKEKCNJmEf9h8CsimXiL2e33s3/e7F7K2Cs3f3dCMkQkMKj4YuCY3K3iR+e7fMaiSjvkX0/5cFGrWpe2uLzOpaExUVqMS/8PX/Re5ey960OLBTZpFA8+IlSBKPQ92zNyUUBsosN58uIY0k8f+/ONCoYytkVuhWzVwNkYiYbqk5M3NmOVBi41YZ8RsGF7shEtFb5KJ3r969CyixM7OTPeFUxG2IxLO8/9/SvqXlc+/x3h295YzLlj2nIRJQj//nRvc5TEIal8RsXBLVuCQwIgoq/u80DomP6HEOk/iOS+IJLonZOCT+ReOQ+Lkbh0QKLonbOCR+7MYhsRqHBJrVcIl/1TgklqKLQyQ+tGKIgyQOqXpjig94diZRAgAXmDX6jyWafAAAAABJRU5ErkJggg====== MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4C2QzW40V7z3TRg X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=tavi.co.uk header.s=selector1 header.b=iuIpaID5; dmarc=pass (policy=none) header.from=tavi.co.uk; spf=pass (mx1.freebsd.org: domain of rde@tavi.co.uk designates 81.187.145.130 as permitted sender) smtp.mailfrom=rde@tavi.co.uk X-Spamd-Result: default: False [-2.72 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[tavi.co.uk:s=selector1]; NEURAL_HAM_MEDIUM(-1.03)[-1.034]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+a:kipling.tavi.co.uk]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-ports@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-0.98)[-0.983]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[tavi.co.uk:+]; DMARC_POLICY_ALLOW(-0.50)[tavi.co.uk,none]; NEURAL_HAM_SHORT(-0.80)[-0.798]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:20712, ipnet:81.187.0.0/16, country:GB]; MAILMAN_DEST(0.00)[freebsd-ports] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2020 21:21:28 -0000 On Thu, 1 Oct 2020 23:11:49 +0200 Moritz Schmitt wrote: > What's the recommended approach? Just ignore the warnings and don't > modify the software since it builds anyway? Or create patches even > though they don't seem to be strictly necessary? I tend to patch them away, as if they don't fix them upstream they might obscure more important warnings when building the next version. And it's neater! I should say that I usually have to deal with more than three warnings; you case is more marginal.