From owner-cvs-all@FreeBSD.ORG Thu Dec 28 18:59:35 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2399716A47B for ; Thu, 28 Dec 2006 18:59:35 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outS.internet-mail-service.net (outS.internet-mail-service.net [216.240.47.242]) by mx1.freebsd.org (Postfix) with ESMTP id 01D0113C46F for ; Thu, 28 Dec 2006 18:59:34 +0000 (UTC) (envelope-from julian@elischer.org) Received: from shell.idiom.com (HELO idiom.com) (216.240.47.20) by out.internet-mail-service.net (qpsmtpd/0.32) with ESMTP; Thu, 28 Dec 2006 10:28:32 -0800 Received: from [10.251.23.175] (nat.ironport.com [63.251.108.100]) by idiom.com (8.12.11/8.12.11) with ESMTP id kBSIjSUl026398; Thu, 28 Dec 2006 10:45:29 -0800 (PST) (envelope-from julian@elischer.org) Message-ID: <459410BB.7000907@elischer.org> Date: Thu, 28 Dec 2006 10:45:15 -0800 From: Julian Elischer User-Agent: Thunderbird 1.5.0.9 (Macintosh/20061207) MIME-Version: 1.0 To: Gleb Smirnoff References: <200612281321.kBSDLsfb022830@repoman.freebsd.org> <20061228133525.GN46380@FreeBSD.org> In-Reply-To: <20061228133525.GN46380@FreeBSD.org> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netgraph ng_ppp.c ng_ppp.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Dec 2006 18:59:35 -0000 Gleb Smirnoff wrote: > On Thu, Dec 28, 2006 at 01:21:54PM +0000, Gleb Smirnoff wrote: > T> glebius 2006-12-28 13:21:54 UTC > T> > T> FreeBSD src repository > T> > T> Modified files: > T> sys/netgraph ng_ppp.c ng_ppp.h > T> Log: > T> Before this commit, if the compression is enabled the, ng_ppp(4) > T> node would send every outgoing frame to the "compress" hook. > T> Packets received on the "compress" hook were expected to be > T> compressed and PROT_COMPD tag was put on them unconditionally. > T> > T> After this commit an alternative compression mode can be set. > T> In this mode the node doesn't put the PROT_COMPD, the compressor > T> should put it itself. This is important for such kind of > T> compressors, that can submit uncompressed frames. > T> > T> Before this commit, if the decompression is enabled, the ng_ppp(4) > T> node would send and incoming frame to the "decompress" hook > T> only if it has the PROT_COMPD proto tag on it. > T> > T> After this commit an alternative decompression mode can be set. > T> In this mode the node sends all the incoming packets to the > T> decompression hook. This is important for such kind of compressors > T> that need uncompressed packets too, to keep their library in sync. > T> > T> These new features will be used in new version of mpd4, and in new > T> compressor nodes. > T> > T> Submitted by: Alexander Motin > > This commit obfuscates ng_ppp_input() further. We have plans to > toss some code in the ng_ppp(4), utilizing per-hook receive data > methods to make its input code path more clear for reading. that's why I made per-hook input methods :-) >