From owner-freebsd-fs@FreeBSD.ORG Fri Mar 11 19:31:58 2005 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DDFB416A4CE for ; Fri, 11 Mar 2005 19:31:58 +0000 (GMT) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id A10ED43D3F for ; Fri, 11 Mar 2005 19:31:58 +0000 (GMT) (envelope-from sam@errno.com) Received: from [66.127.85.91] (sam@[66.127.85.91]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id j2BJVums073365 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 11 Mar 2005 11:31:57 -0800 (PST) (envelope-from sam@errno.com) Message-ID: <4231F290.2060308@errno.com> Date: Fri, 11 Mar 2005 11:33:36 -0800 From: Sam Leffler User-Agent: Mozilla Thunderbird 1.0RC1 (X11/20041208) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ian Dowse References: <200503111910.aa12186@salmon.maths.tcd.ie> In-Reply-To: <200503111910.aa12186@salmon.maths.tcd.ie> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: fs@freebsd.org Subject: Re: dirhash potential bug X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2005 19:31:59 -0000 Ian Dowse wrote: > In message <4231D417.9060705@errno.com>, Sam Leffler writes: > >>Coverity's analysis tool claims there might be a null bp dereferenced in >>ufsdirhash_lookup. Attached is a patch to add a KASSERT but it'd be >>good for someone more familiar with the code to check if a change is >>required. > > > Sam, maybe you missed my reply to your original message about this? > Here it is again anyway. Never saw it; thanks for re-sending. Sam