From owner-svn-ports-head@FreeBSD.ORG  Tue Mar 31 07:51:22 2015
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 533C4B29;
 Tue, 31 Mar 2015 07:51:22 +0000 (UTC)
Received: from f10.opsec.eu (f10.opsec.eu [IPv6:2001:14f8:200:4::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 10CC7907;
 Tue, 31 Mar 2015 07:51:22 +0000 (UTC)
Received: from pi by f10.opsec.eu with local (Exim 4.85 (FreeBSD))
 (envelope-from <pi@FreeBSD.org>)
 id 1YcqxD-000J4g-CO; Tue, 31 Mar 2015 09:51:19 +0200
Date: Tue, 31 Mar 2015 09:51:19 +0200
From: Kurt Jaeger <pi@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r382799 - head/mail/rainloop
Message-ID: <20150331075119.GG1017@f10.opsec.eu>
References: <201503310733.t2V7XuXK025802@svn.freebsd.org>
 <20150331074530.GA96248@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150331074530.GA96248@FreeBSD.org>
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 Kurt Jaeger <pi@FreeBSD.org>, ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Mar 2015 07:51:22 -0000

Hi!

> On Tue, Mar 31, 2015 at 07:33:56AM +0000, Kurt Jaeger wrote:
> > New Revision: 382799
> > URL: https://svnweb.freebsd.org/changeset/ports/382799
> > 
> > Log:
> >   mail/rainloop: Add an OPTIONS_DEFAULT
> 
> May I ask, why MYSQL was preferred over SQLITE?

That's what the submitter provided.

> > +OPTIONS_SINGLE=	DB
> > +OPTIONS_SINGLE_DB=	MYSQL PGSQL SQLITE
> > +OPTIONS_DEFAULT=	MYSQL
> 
> Two mistakes here: 1) wrong position of OPTIONS_* block (should be lower in
> the Makefile), and 2) it duplicates existing knobs (OPTIONS_SINGLE and
> OPTIONS_SINGLE_DB).

You're right, I was not fully awake 8-(

-- 
pi@FreeBSD.org         +49 171 3101372                5 years to go !