From owner-freebsd-hackers@FreeBSD.ORG Sun Nov 25 19:29:13 2012 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8BC81BBA; Sun, 25 Nov 2012 19:29:13 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id C37C88FC13; Sun, 25 Nov 2012 19:29:12 +0000 (UTC) Received: by mail-la0-f54.google.com with SMTP id j13so9985500lah.13 for ; Sun, 25 Nov 2012 11:29:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=iBQJyyysg7i+d7gyJUf6QxeuNonTWvOuxhr8EbVExhw=; b=Zm3F3r479lWgUuFBvwHLx1CaUPeNp0Azo5gTB3/zICvwox4Htou8DOhX0J+hkmmSz/ yJ5N7IV6yt3CZuZ3OvMNA8qx/u5gizVkm84f/TFkoTT+U+6yl8ppgSNsX1lGfdlaQrYN 1xr35606ulmA2mRBGuvKiukyV6vbPuW9TTJ5C5gqoVHiytX/6db6g30e8K9FtOMjt/+v 06S6NyL37eIfkrrIRWlexHTpKrTGDmu72Ji0SXUeZ2Bl7j+eiQGjvZ3HcznwExSL2QuU MPkmuuJ5vMzsB/GzBz4UxSPoYCmyQWjCJav4MR63Y45KEsvINE9JTVV73snJVbRt75gj tR2w== MIME-Version: 1.0 Received: by 10.152.129.197 with SMTP id ny5mr8861417lab.43.1353871751433; Sun, 25 Nov 2012 11:29:11 -0800 (PST) Sender: asmrookie@gmail.com Received: by 10.112.134.5 with HTTP; Sun, 25 Nov 2012 11:29:11 -0800 (PST) In-Reply-To: <50B26179.4040205@FreeBSD.org> References: <50A5F12C.1050902@FreeBSD.org> <50A63D1D.9090500@FreeBSD.org> <50A65208.4050804@FreeBSD.org> <50B21545.5060807@FreeBSD.org> <50B22DA0.9080207@FreeBSD.org> <50B26179.4040205@FreeBSD.org> Date: Sun, 25 Nov 2012 20:29:11 +0100 X-Google-Sender-Auth: MOzvdOA-yMhiOXKj_-Blc24vQIs Message-ID: Subject: Re: stop_cpus_hard when multiple CPUs are panicking from an NMI From: Attilio Rao To: Andriy Gapon Content-Type: text/plain; charset=UTF-8 Cc: freebsd-hackers@freebsd.org, Ryan Stone X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Nov 2012 19:29:13 -0000 On Sun, Nov 25, 2012 at 7:20 PM, Andriy Gapon wrote: > on 25/11/2012 20:05 Attilio Rao said the following: >> If you really want to do something like that please rename >> s/generic_stop_cpus/generic_stop_butself() or similar convention and I >> may be not opposed to it. > > As we discussed before, anything else besides "all but self" does not make > sense. So I am not sure what's the point of being that verbose in the naming. Avoid POLA violation and show there is a change in the KPI? I'd personally prefer a new name, but I'm open on not getting it. Attilio -- Peace can only be achieved by understanding - A. Einstein